openstack/puppet-nova
Code Issues Proposed changes

Deprecate nova::workarounds::enable_numa_live_migration

Browse Source 
workarounds/enable_numa_live_migration was deprecated in nova
since Train release[1], the corresponding hieradata should be
deprecated.

[1] If649218db86a04db744990ec0139b4f0b1e79ad6

Change-Id: I02325d7ee5b073f018420abe38762362142818b6
This commit is contained in:
Takashi Kajinami
2020-01-18 22:45:33 +09:00
parent 7c7e07027a
commit 1e0af55835
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
manifests/workarounds.pp
View File

@@ -4,17 +4,22 @@
# #
# === Parameters: # === Parameters:
# #
# DEPRECATED
#
# [*enable_numa_live_migration*] # [*enable_numa_live_migration*]
# (optional) Whether to enable live migration for NUMA topology instances. # (optional) Whether to enable live migration for NUMA topology instances.
# Defaults to false # Defaults to undef
# #
class nova::workarounds ( class nova::workarounds (
$enable_numa_live_migration = false, # DEPRECATED PARAMETER
$enable_numa_live_migration = undef,
) { ) {
nova_config { if $enable_numa_live_migration != undef {
'workarounds/enable_numa_live_migration': value => $enable_numa_live_migration; warning('The enable_numa_live_migration parameter is deprecated')
nova_config {
'workarounds/enable_numa_live_migration': value => $enable_numa_live_migration;
}
} }
} }

2
spec/classes/nova_workarounds_spec.rb
View File

@@ -9,7 +9,7 @@ describe 'nova::workarounds' do
shared_examples 'nova::workarounds' do shared_examples 'nova::workarounds' do
context 'with default parameters' do context 'with default parameters' do
it { is_expected.to contain_nova_config('workarounds/enable_numa_live_migration').with_value(false) } it { is_expected.not_to contain_resources('nova_config') }
end end
context 'with overridden parameters' do context 'with overridden parameters' do