From 2aa5cda3955862adaf1b62af8837ec5971a477a1 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Tue, 19 Apr 2022 08:35:15 +0900 Subject: [PATCH] Remove redundant logic to detect undef value When passing "undef" to parameters, Puppet internally replaces it by the default value. So if a parameter defaults to a non-undef value, there is no chance the parameter is set to "undef". Change-Id: Ib185b7c883ed6e9ae68bd0ad98f6ecf44c0df93c --- manifests/compute/libvirt/virtlogd.pp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/manifests/compute/libvirt/virtlogd.pp b/manifests/compute/libvirt/virtlogd.pp index 9914dab03..7929e3d14 100644 --- a/manifests/compute/libvirt/virtlogd.pp +++ b/manifests/compute/libvirt/virtlogd.pp @@ -49,20 +49,6 @@ class nova::compute::libvirt::virtlogd ( include nova::deps require nova::compute::libvirt - [ - 'log_level', - 'log_filters', - 'log_outputs', - 'max_clients', - 'admin_max_clients', - 'max_size', - 'max_backups', - ].each |String $virtlogd_opt| { - if getvar($virtlogd_opt) == undef { - warning("Usage of undef for ${virtlogd_opt} has been deprecated.") - } - } - virtlogd_config { 'log_level': value => pick($log_level, $::os_service_default); 'log_filters': value => pick($log_filters, $::os_service_default), quote => true;