openstack
/
puppet-nova
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
This commit is contained in:
Gerrit User 13344 2014-12-23 19:12:01 +00:00 committed by Gerrit Code Review
parent 137ee23598
commit 3630d4996b
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ff057aefbab2a6393fee30997d290e486fa15d65
View File

@ -88,6 +88,24 @@
"revId": "ff057aefbab2a6393fee30997d290e486fa15d65",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a961159_e78480d4",
"filename": "manifests/migration/libvirt.pp",
"patchSetId": 6
},
"lineNbr": 9,
"author": {
"id": 13344
},
"writtenOn": "2014-12-23T19:12:01Z",
"side": 1,
"message": "As our $host_uuid is being generated on every puppet run and generates new value each time, then host_uuid value in config will be changed each time, because of \u0027match\u0027 just looks for the line and does not have any \u0027check\u0027 logic.\n\nAnyway you can easily true Yanis\u0027 code with fake file and variables.",
"parentUuid": "3a961159_ecf467f2",
"revId": "ff057aefbab2a6393fee30997d290e486fa15d65",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}