From 4042642e4941bf3dac5d305c876726a47a1ebf6f Mon Sep 17 00:00:00 2001 From: ZhongShengping Date: Thu, 14 Feb 2019 17:23:07 +0800 Subject: [PATCH] Service_token_roles_required missing in the server config file Service_token_roles_required missing in the server config file which allows backwards compatibility to ensure that the service tokens are compared against a list of possible roles for validity. Change-Id: I826a09ede0d15502da69cd0b48c5e54854e07f6c Closes-Bug: 1778198 --- manifests/keystone/authtoken.pp | 8 ++++++++ .../service_token_roles_required-98f582fb58fe82ee.yaml | 5 +++++ spec/classes/nova_keystone_authtoken_spec.rb | 3 +++ 3 files changed, 16 insertions(+) create mode 100644 releasenotes/notes/service_token_roles_required-98f582fb58fe82ee.yaml diff --git a/manifests/keystone/authtoken.pp b/manifests/keystone/authtoken.pp index e70baeb5c..ccc312e75 100644 --- a/manifests/keystone/authtoken.pp +++ b/manifests/keystone/authtoken.pp @@ -161,6 +161,12 @@ # (in seconds). Set to -1 to disable caching completely. Integer value # Defaults to $::os_service_default. # +# [*service_token_roles_required*] +# (optional) backwards compatibility to ensure that the service tokens are +# compared against a list of possible roles for validity +# true/false +# Defaults to $::os_service_default. +# # DEPRECATED PARAMETERS # # [*check_revocations_for_cached*] @@ -213,6 +219,7 @@ class nova::keystone::authtoken( $manage_memcache_package = false, $region_name = $::os_service_default, $token_cache_time = $::os_service_default, + $service_token_roles_required = $::os_service_default, # DEPRECATED PARAMETERS $check_revocations_for_cached = undef, $hash_algorithms = undef, @@ -265,5 +272,6 @@ class nova::keystone::authtoken( manage_memcache_package => $manage_memcache_package, region_name => $region_name, token_cache_time => $token_cache_time, + service_token_roles_required => $service_token_roles_required, } } diff --git a/releasenotes/notes/service_token_roles_required-98f582fb58fe82ee.yaml b/releasenotes/notes/service_token_roles_required-98f582fb58fe82ee.yaml new file mode 100644 index 000000000..60a452172 --- /dev/null +++ b/releasenotes/notes/service_token_roles_required-98f582fb58fe82ee.yaml @@ -0,0 +1,5 @@ +--- +features: + - Service_token_roles_required missing in the server config file which + allows backwards compatibility to ensure that the service tokens are + compared against a list of possible roles for validity. diff --git a/spec/classes/nova_keystone_authtoken_spec.rb b/spec/classes/nova_keystone_authtoken_spec.rb index 3a615dfd5..82d05d61e 100644 --- a/spec/classes/nova_keystone_authtoken_spec.rb +++ b/spec/classes/nova_keystone_authtoken_spec.rb @@ -42,6 +42,7 @@ describe 'nova::keystone::authtoken' do is_expected.to contain_nova_config('keystone_authtoken/memcached_servers').with_value('') is_expected.to contain_nova_config('keystone_authtoken/region_name').with_value('') is_expected.to contain_nova_config('keystone_authtoken/token_cache_time').with_value('') + is_expected.to contain_nova_config('keystone_authtoken/service_token_roles_required').with_value('') end end @@ -82,6 +83,7 @@ describe 'nova::keystone::authtoken' do :manage_memcache_package => true, :region_name => 'region2', :token_cache_time => '301', + :service_token_roles_required => false, }) end @@ -117,6 +119,7 @@ describe 'nova::keystone::authtoken' do is_expected.to contain_nova_config('keystone_authtoken/memcached_servers').with_value('memcached01:11211,memcached02:11211') is_expected.to contain_nova_config('keystone_authtoken/region_name').with_value(params[:region_name]) is_expected.to contain_nova_config('keystone_authtoken/token_cache_time').with_value(params[:token_cache_time]) + is_expected.to contain_nova_config('keystone_authtoken/service_token_roles_required').with_value(params[:service_token_roles_required]) end it 'installs python memcache package' do