Merge pull request #45 from bodepd/diablo_final

Diablo final

lib/puppet/provider/nova_admin/default.rb

@@ -1,16 +0,0 @@
-Puppet::Type.type(:nova_admin).provide(:default) do
-
-  desc "This is a default provider that does nothing. This allows us to install nova-manage on the same puppet run where we want to use it."
-
-  def create
-    return false
-  end
-
-  def destroy
-    return false
-  end
-
-  def exists?
-    fail('This is just the default provider for nova_admin, all it does is fail')
-  end
-end

lib/puppet/provider/nova_admin/nova_manage.rb

@@ -2,9 +2,7 @@ Puppet::Type.type(:nova_admin).provide(:nova_manage) do
 
   desc "Manage nova admin user"
 
-  defaultfor :kernel => 'Linux'
-
-  commands :nova_manage => 'nova-manage'
+  optional_commands :nova_manage => 'nova-manage'
 
   def exists?
     nova_manage("user", "list").match(/^#{resource[:name]}$/)

lib/puppet/provider/nova_config/parsed.rb

@@ -14,7 +14,7 @@ Puppet::Type.type(:nova_config).provide(
   text_line :blank, :match => /^\s*$/;
 
   record_line :parsed,
-    :fields => %w{line}, 
+    :fields => %w{line},
     :match => /--(.*)/ ,
     :post_parse => proc { |hash|
       Puppet.debug("nova config line:#{hash[:line]} has been parsed") 

lib/puppet/provider/nova_network/default.rb

@@ -1,16 +0,0 @@
-Puppet::Type.type(:nova_network).provide(:default) do
-
-  desc "This is a default provider that does nothing. This allows us to install nova-manage on the same puppet run where we want to use it."
-
-  def create
-    return false
-  end
-
-  def destroy
-    return false
-  end
-
-  def exists?
-    fail('This is just the default provider for nova_admin, all it does is fail')
-  end
-end

lib/puppet/provider/nova_network/nova_manage.rb

@@ -2,13 +2,14 @@ Puppet::Type.type(:nova_network).provide(:nova_manage) do
 
   desc "Manage nova network"
 
-  defaultfor :kernel => 'Linux'
-
-  commands :nova_manage => 'nova-manage'
+  optional_commands :nova_manage => 'nova-manage'
 
   def exists?
     begin
-      nova_manage("network", "list").match(/^#{resource[:network]}\/[0-9]{1,2} /)
+      network_list = nova_manage("network", "list")
+      return network_list.split("\n")[1..-1].detect do |n|
+        n =~ /^(\S+)\s+(#{resource[:network]})/
+      end
     rescue
       return false
     end

lib/puppet/provider/nova_project/default.rb

@@ -1,17 +0,0 @@
-Puppet::Type.type(:nova_project).provide(:default) do
-
-  desc "This is a default provider that does nothing. This allows us to install nova-manage on the same puppet run where we want to use it."
-
-  def create
-    return false
-  end
-
-  def destroy
-    return false
-  end
-
-  def exists?
-    fail('This is just the default provider for nova_project, all it does is fail')
-  end
-
-end

lib/puppet/provider/nova_project/nova_manage.rb

@@ -2,9 +2,7 @@ Puppet::Type.type(:nova_project).provide(:nova_manage) do
 
   desc "Manage nova project"
 
-  defaultfor :kernel => 'Linux'
-
-  commands :nova_manage => 'nova-manage'
+  optional_commands :nova_manage => 'nova-manage'
 
   def exists?
     nova_manage("project", "list").match(/^#{resource[:name]}$/)

manifests/manage/network.pp

@@ -7,7 +7,6 @@ define nova::manage::network ( $network, $available_ips ) {
     ensure        => present,
     network       => $network,
     available_ips => $available_ips,
-    provider      => 'nova_manage',
     notify        => Exec["nova-db-sync"],
   }
 }

manifests/manage/project.pp

@@ -5,7 +5,6 @@ define nova::manage::project ( $owner ) {
 
   nova_project { $name:
     ensure   => present,
-    provider => 'nova_manage',
     owner    => $owner,
     notify   => Exec["nova-db-sync"],
     require  => Nova::Manage::Admin[$owner],

manifests/network/bridge.pp

@@ -1,7 +1,7 @@
 # bridge.pp
 define nova::network::bridge ( $ip, $netmask = "255.255.255.0" )
 {
-  case $operatingsystem {
+  case $::operatingsystem {
 
     'debian', 'ubuntu': {
       $context = "/files/etc/network/interfaces"

spec/unit/type/nova_config_spec.rb

@@ -15,7 +15,7 @@ describe 'Puppet::Type.type(:nova_config)' do
     Puppet::Type.type(:nova_config).new(:name => 'foo', :ensure => :absent)
   end
   it 'should require a value when ensure is present' do
-    expect { Puppet::Type.type(:nova_config).new(:name => 'foo', :ensure => :present) }.should raise_error(Puppet::Error, 'Property value must be set when ensure is present')
+    expect { Puppet::Type.type(:nova_config).new(:name => 'foo', :ensure => :present) }.should raise_error(Puppet::Error, /Property value must be set/)
   end
   it 'should accept a valid value' do
     @nova_config[:value] = 'bar'