openstack
/
puppet-nova
Code Issues Proposed changes

Fix package dependency to be on title instead of name 

The service in generic_service should require the related package
by title and not by name.

Change-Id: If4aacb10800b274810845b5656c3c6e0be1fd255
This commit is contained in:
dgurtner 2015-03-27 15:30:44 +01:00
parent a0d934b6e2
commit 47c741f8b4
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/generic_service.pp
View File

@ -56,7 +56,7 @@ define nova::generic_service(
name => $service_name,
enable => $enabled,
hasstatus => true,
require => [Package['nova-common'], Package[$package_name]],
require => [Package['nova-common'], Package[$nova_title]],
}
}
}

2
spec/classes/nova_vnc_proxy_spec.rb
View File

@ -80,6 +80,8 @@ describe 'nova::vncproxy' do
:ensure => 'present'
)}
it { is_expected.to compile.with_all_deps }
end
end

2
spec/defines/nova_generic_service_spec.rb
View File

@ -26,7 +26,7 @@ describe 'nova::generic_service' do
'name' => 'food',
'ensure' => 'running',
'enable' => true,
'require' => ['Package[nova-common]', 'Package[foo]']
'require' => ['Package[nova-common]', 'Package[nova-foo]']
)}
end
end