From de886cd1dda892aa74ebeae00e0d17d391862f86 Mon Sep 17 00:00:00 2001 From: Bogdan Dobrelya Date: Mon, 29 Aug 2022 15:00:32 +0200 Subject: [PATCH] Wire-in max_client_requests for libvirt Libvirt setting for (admin_/)max_client_requests is an important configuration to be tweaked when serving long running requests. Signed-off-by: Bogdan Dobrelya Change-Id: I2d0ab2472f940ef6edac662e167033881ab09086 --- manifests/compute/libvirt/libvirtd.pp | 41 ++++++++++++------- manifests/compute/libvirt/virtnodedevd.pp | 37 +++++++++++------ manifests/compute/libvirt/virtproxyd.pp | 41 ++++++++++++------- manifests/compute/libvirt/virtqemud.pp | 37 +++++++++++------ manifests/compute/libvirt/virtsecretd.pp | 37 +++++++++++------ ..._max_client_requests-1709c1d7a282264d.yaml | 5 +++ .../nova_compute_libvirt_libvirtd_spec.rb | 20 +++++---- .../nova_compute_libvirt_virtnodedevd_spec.rb | 18 +++++--- .../nova_compute_libvirt_virtproxyd_spec.rb | 20 +++++---- .../nova_compute_libvirt_virtqemud_spec.rb | 18 +++++--- .../nova_compute_libvirt_virtsecretd_spec.rb | 18 +++++--- 11 files changed, 196 insertions(+), 96 deletions(-) create mode 100644 releasenotes/notes/nova_libvirt_max_client_requests-1709c1d7a282264d.yaml diff --git a/manifests/compute/libvirt/libvirtd.pp b/manifests/compute/libvirt/libvirtd.pp index f2162eaa3..70e22917e 100644 --- a/manifests/compute/libvirt/libvirtd.pp +++ b/manifests/compute/libvirt/libvirtd.pp @@ -28,6 +28,15 @@ # on administrative socket. # Defaults to $::os_service_default # +# [*max_client_requests*] +# Limit on concurrent requests from a single client connection. +# Defaults to $::os_service_default +# +# [*admin_max_client_requests*] +# Limit on concurrent requests from a single client connection +# for the admin interface. +# Defaults to $::os_service_default +# # [*tls_priority*] # (optional) Override the compile time default TLS priority string. The # default is usually "NORMAL" unless overridden at build time. @@ -40,13 +49,15 @@ # Defaults to $::os_service_default # class nova::compute::libvirt::libvirtd ( - $log_level = $::os_service_default, - $log_filters = $::os_service_default, - $log_outputs = $::os_service_default, - $max_clients = $::os_service_default, - $admin_max_clients = $::os_service_default, - $tls_priority = $::os_service_default, - $ovs_timeout = $::os_service_default, + $log_level = $::os_service_default, + $log_filters = $::os_service_default, + $log_outputs = $::os_service_default, + $max_clients = $::os_service_default, + $admin_max_clients = $::os_service_default, + $max_client_requests = $::os_service_default, + $admin_max_client_requests = $::os_service_default, + $tls_priority = $::os_service_default, + $ovs_timeout = $::os_service_default, ) { include nova::deps @@ -57,12 +68,14 @@ class nova::compute::libvirt::libvirtd ( $ovs_timeout_real = pick($::nova::compute::libvirt::ovs_timeout, $ovs_timeout) libvirtd_config { - 'log_level': value => $log_level; - 'log_filters': value => $log_filters_real, quote => true; - 'log_outputs': value => $log_outputs_real, quote => true; - 'max_clients': value => $max_clients; - 'admin_max_clients': value => $admin_max_clients; - 'tls_priority': value => $tls_priority_real, quote => true; - 'ovs_timeout': value => $ovs_timeout_real; + 'log_level': value => $log_level; + 'log_filters': value => $log_filters_real, quote => true; + 'log_outputs': value => $log_outputs_real, quote => true; + 'max_clients': value => $max_clients; + 'admin_max_clients': value => $admin_max_clients; + 'max_client_requests': value => $max_client_requests; + 'admin_max_client_requests': value => $admin_max_client_requests; + 'tls_priority': value => $tls_priority_real, quote => true; + 'ovs_timeout': value => $ovs_timeout_real; } } diff --git a/manifests/compute/libvirt/virtnodedevd.pp b/manifests/compute/libvirt/virtnodedevd.pp index c13ab38c0..1386e41b5 100644 --- a/manifests/compute/libvirt/virtnodedevd.pp +++ b/manifests/compute/libvirt/virtnodedevd.pp @@ -28,27 +28,40 @@ # on administrative socket. # Defaults to $::os_service_default # +# [*max_client_requests*] +# Limit on concurrent requests from a single client connection. +# Defaults to $::os_service_default +# +# [*admin_max_client_requests*] +# Limit on concurrent requests from a single client connection +# for the admin interface. +# Defaults to $::os_service_default +# # [*ovs_timeout*] # (optional) A timeout for openvswitch calls made by libvirt # Defaults to $::os_service_default # class nova::compute::libvirt::virtnodedevd ( - $log_level = $::os_service_default, - $log_filters = $::os_service_default, - $log_outputs = $::os_service_default, - $max_clients = $::os_service_default, - $admin_max_clients = $::os_service_default, - $ovs_timeout = $::os_service_default, + $log_level = $::os_service_default, + $log_filters = $::os_service_default, + $log_outputs = $::os_service_default, + $max_clients = $::os_service_default, + $admin_max_clients = $::os_service_default, + $max_client_requests = $::os_service_default, + $admin_max_client_requests = $::os_service_default, + $ovs_timeout = $::os_service_default, ) { include nova::deps virtnodedevd_config { - 'log_level': value => $log_level; - 'log_filters': value => $log_filters, quote => true; - 'log_outputs': value => $log_outputs, quote => true; - 'max_clients': value => $max_clients; - 'admin_max_clients': value => $admin_max_clients; - 'ovs_timeout': value => $ovs_timeout; + 'log_level': value => $log_level; + 'log_filters': value => $log_filters, quote => true; + 'log_outputs': value => $log_outputs, quote => true; + 'max_clients': value => $max_clients; + 'admin_max_clients': value => $admin_max_clients; + 'max_client_requests': value => $max_client_requests; + 'admin_max_client_requests': value => $admin_max_client_requests; + 'ovs_timeout': value => $ovs_timeout; } } diff --git a/manifests/compute/libvirt/virtproxyd.pp b/manifests/compute/libvirt/virtproxyd.pp index dc3a39c82..1dabe0556 100644 --- a/manifests/compute/libvirt/virtproxyd.pp +++ b/manifests/compute/libvirt/virtproxyd.pp @@ -28,6 +28,15 @@ # on administrative socket. # Defaults to $::os_service_default # +# [*max_client_requests*] +# Limit on concurrent requests from a single client connection. +# Defaults to $::os_service_default +# +# [*admin_max_client_requests*] +# Limit on concurrent requests from a single client connection +# for the admin interface. +# Defaults to $::os_service_default +# # [*ovs_timeout*] # (optional) A timeout for openvswitch calls made by libvirt # Defaults to $::os_service_default @@ -40,24 +49,28 @@ # Defaults to $::os_service_default # class nova::compute::libvirt::virtproxyd ( - $log_level = $::os_service_default, - $log_filters = $::os_service_default, - $log_outputs = $::os_service_default, - $max_clients = $::os_service_default, - $admin_max_clients = $::os_service_default, - $ovs_timeout = $::os_service_default, - $tls_priority = $::os_service_default, + $log_level = $::os_service_default, + $log_filters = $::os_service_default, + $log_outputs = $::os_service_default, + $max_clients = $::os_service_default, + $admin_max_clients = $::os_service_default, + $max_client_requests = $::os_service_default, + $admin_max_client_requests = $::os_service_default, + $ovs_timeout = $::os_service_default, + $tls_priority = $::os_service_default, ) { include nova::deps virtproxyd_config { - 'log_level': value => $log_level; - 'log_filters': value => $log_filters, quote => true; - 'log_outputs': value => $log_outputs, quote => true; - 'max_clients': value => $max_clients; - 'admin_max_clients': value => $admin_max_clients; - 'ovs_timeout': value => $ovs_timeout; - 'tls_priority': value => $tls_priority, quote => true; + 'log_level': value => $log_level; + 'log_filters': value => $log_filters, quote => true; + 'log_outputs': value => $log_outputs, quote => true; + 'max_clients': value => $max_clients; + 'admin_max_clients': value => $admin_max_clients; + 'max_client_requests': value => $max_client_requests; + 'admin_max_client_requests': value => $admin_max_client_requests; + 'ovs_timeout': value => $ovs_timeout; + 'tls_priority': value => $tls_priority, quote => true; } } diff --git a/manifests/compute/libvirt/virtqemud.pp b/manifests/compute/libvirt/virtqemud.pp index 6a00da4da..9414b445d 100644 --- a/manifests/compute/libvirt/virtqemud.pp +++ b/manifests/compute/libvirt/virtqemud.pp @@ -28,28 +28,41 @@ # on administrative socket. # Defaults to $::os_service_default # +# [*max_client_requests*] +# Limit on concurrent requests from a single client connection. +# Defaults to $::os_service_default +# +# [*admin_max_client_requests*] +# Limit on concurrent requests from a single client connection +# for the admin interface. +# Defaults to $::os_service_default +# # [*ovs_timeout*] # (optional) A timeout for openvswitch calls made by libvirt # Defaults to $::os_service_default # # class nova::compute::libvirt::virtqemud ( - $log_level = $::os_service_default, - $log_filters = $::os_service_default, - $log_outputs = $::os_service_default, - $max_clients = $::os_service_default, - $admin_max_clients = $::os_service_default, - $ovs_timeout = $::os_service_default, + $log_level = $::os_service_default, + $log_filters = $::os_service_default, + $log_outputs = $::os_service_default, + $max_clients = $::os_service_default, + $admin_max_clients = $::os_service_default, + $max_client_requests = $::os_service_default, + $admin_max_client_requests = $::os_service_default, + $ovs_timeout = $::os_service_default, ) { include nova::deps virtqemud_config { - 'log_level': value => $log_level; - 'log_filters': value => $log_filters, quote => true; - 'log_outputs': value => $log_outputs, quote => true; - 'max_clients': value => $max_clients; - 'admin_max_clients': value => $admin_max_clients; - 'ovs_timeout': value => $ovs_timeout; + 'log_level': value => $log_level; + 'log_filters': value => $log_filters, quote => true; + 'log_outputs': value => $log_outputs, quote => true; + 'max_clients': value => $max_clients; + 'admin_max_clients': value => $admin_max_clients; + 'max_client_requests': value => $max_client_requests; + 'admin_max_client_requests': value => $admin_max_client_requests; + 'ovs_timeout': value => $ovs_timeout; } } diff --git a/manifests/compute/libvirt/virtsecretd.pp b/manifests/compute/libvirt/virtsecretd.pp index 10d407ac4..0023c1b7f 100644 --- a/manifests/compute/libvirt/virtsecretd.pp +++ b/manifests/compute/libvirt/virtsecretd.pp @@ -28,27 +28,40 @@ # on administrative socket. # Defaults to $::os_service_default # +# [*max_client_requests*] +# Limit on concurrent requests from a single client connection. +# Defaults to $::os_service_default +# +# [*admin_max_client_requests*] +# Limit on concurrent requests from a single client connection +# for the admin interface. +# Defaults to $::os_service_default +# # [*ovs_timeout*] # (optional) A timeout for openvswitch calls made by libvirt # Defaults to $::os_service_default # class nova::compute::libvirt::virtsecretd ( - $log_level = $::os_service_default, - $log_filters = $::os_service_default, - $log_outputs = $::os_service_default, - $max_clients = $::os_service_default, - $admin_max_clients = $::os_service_default, - $ovs_timeout = $::os_service_default, + $log_level = $::os_service_default, + $log_filters = $::os_service_default, + $log_outputs = $::os_service_default, + $max_clients = $::os_service_default, + $admin_max_clients = $::os_service_default, + $max_client_requests = $::os_service_default, + $admin_max_client_requests = $::os_service_default, + $ovs_timeout = $::os_service_default, ) { include nova::deps virtsecretd_config { - 'log_level': value => $log_level; - 'log_filters': value => $log_filters, quote => true; - 'log_outputs': value => $log_outputs, quote => true; - 'max_clients': value => $max_clients; - 'admin_max_clients': value => $admin_max_clients; - 'ovs_timeout': value => $ovs_timeout; + 'log_level': value => $log_level; + 'log_filters': value => $log_filters, quote => true; + 'log_outputs': value => $log_outputs, quote => true; + 'max_clients': value => $max_clients; + 'admin_max_clients': value => $admin_max_clients; + 'max_client_requests': value => $max_client_requests; + 'admin_max_client_requests': value => $admin_max_client_requests; + 'ovs_timeout': value => $ovs_timeout; } } diff --git a/releasenotes/notes/nova_libvirt_max_client_requests-1709c1d7a282264d.yaml b/releasenotes/notes/nova_libvirt_max_client_requests-1709c1d7a282264d.yaml new file mode 100644 index 000000000..abff0a080 --- /dev/null +++ b/releasenotes/notes/nova_libvirt_max_client_requests-1709c1d7a282264d.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + New parameters ``max_client_requests`` and ``admin_max_client_requests`` + allow to configure corresponding settings for libvirt. diff --git a/spec/classes/nova_compute_libvirt_libvirtd_spec.rb b/spec/classes/nova_compute_libvirt_libvirtd_spec.rb index 7763ddb4b..f2de0235d 100644 --- a/spec/classes/nova_compute_libvirt_libvirtd_spec.rb +++ b/spec/classes/nova_compute_libvirt_libvirtd_spec.rb @@ -27,19 +27,23 @@ eos it { is_expected.to contain_libvirtd_config('log_filters').with_value('').with_quote(true)} it { is_expected.to contain_libvirtd_config('max_clients').with_value('')} it { is_expected.to contain_libvirtd_config('admin_max_clients').with_value('')} + it { is_expected.to contain_libvirtd_config('max_client_requests').with_value('')} + it { is_expected.to contain_libvirtd_config('admin_max_client_requests').with_value('')} it { is_expected.to contain_libvirtd_config('tls_priority').with_value('').with_quote(true)} it { is_expected.to contain_libvirtd_config('ovs_timeout').with_value('')} end context 'with specified parameters' do let :params do - { :log_level => 3, - :log_outputs => '3:syslog', - :log_filters => '1:logging 4:object 4:json 4:event 1:util', - :max_clients => 1024, - :admin_max_clients => 5, - :tls_priority => 'NORMAL', - :ovs_timeout => 20, + { :log_level => 3, + :log_outputs => '3:syslog', + :log_filters => '1:logging 4:object 4:json 4:event 1:util', + :max_clients => 1024, + :admin_max_clients => 5, + :max_client_requests => 42, + :admin_max_client_requests => 55, + :tls_priority => 'NORMAL', + :ovs_timeout => 20, } end @@ -51,6 +55,8 @@ eos it { is_expected.to contain_libvirtd_config('log_filters').with_value(params[:log_filters]).with_quote(true)} it { is_expected.to contain_libvirtd_config('max_clients').with_value(params[:max_clients])} it { is_expected.to contain_libvirtd_config('admin_max_clients').with_value(params[:admin_max_clients])} + it { is_expected.to contain_libvirtd_config('max_client_requests').with_value(params[:max_client_requests])} + it { is_expected.to contain_libvirtd_config('admin_max_client_requests').with_value(params[:admin_max_client_requests])} it { is_expected.to contain_libvirtd_config('tls_priority').with_value(params[:tls_priority]).with_quote(true)} it { is_expected.to contain_libvirtd_config('ovs_timeout').with_value(params[:ovs_timeout])} end diff --git a/spec/classes/nova_compute_libvirt_virtnodedevd_spec.rb b/spec/classes/nova_compute_libvirt_virtnodedevd_spec.rb index 9e2a9ce4f..1f6c35cc2 100644 --- a/spec/classes/nova_compute_libvirt_virtnodedevd_spec.rb +++ b/spec/classes/nova_compute_libvirt_virtnodedevd_spec.rb @@ -18,17 +18,21 @@ describe 'nova::compute::libvirt::virtnodedevd' do it { is_expected.to contain_virtnodedevd_config('log_filters').with_value('').with_quote(true)} it { is_expected.to contain_virtnodedevd_config('max_clients').with_value('')} it { is_expected.to contain_virtnodedevd_config('admin_max_clients').with_value('')} + it { is_expected.to contain_virtnodedevd_config('max_client_requests').with_value('')} + it { is_expected.to contain_virtnodedevd_config('admin_max_client_requests').with_value('')} it { is_expected.to contain_virtnodedevd_config('ovs_timeout').with_value('')} end context 'with specified parameters' do let :params do - { :log_level => 3, - :log_outputs => '3:syslog', - :log_filters => '1:logging 4:object 4:json 4:event 1:util', - :max_clients => 1024, - :admin_max_clients => 5, - :ovs_timeout => 10, + { :log_level => 3, + :log_outputs => '3:syslog', + :log_filters => '1:logging 4:object 4:json 4:event 1:util', + :max_clients => 1024, + :admin_max_clients => 5, + :max_client_requests => 42, + :admin_max_client_requests => 55, + :ovs_timeout => 10, } end @@ -39,6 +43,8 @@ describe 'nova::compute::libvirt::virtnodedevd' do it { is_expected.to contain_virtnodedevd_config('log_filters').with_value(params[:log_filters]).with_quote(true)} it { is_expected.to contain_virtnodedevd_config('max_clients').with_value(params[:max_clients])} it { is_expected.to contain_virtnodedevd_config('admin_max_clients').with_value(params[:admin_max_clients])} + it { is_expected.to contain_virtnodedevd_config('max_client_requests').with_value(params[:max_client_requests])} + it { is_expected.to contain_virtnodedevd_config('admin_max_client_requests').with_value(params[:admin_max_client_requests])} it { is_expected.to contain_virtnodedevd_config('ovs_timeout').with_value(params[:ovs_timeout])} end end diff --git a/spec/classes/nova_compute_libvirt_virtproxyd_spec.rb b/spec/classes/nova_compute_libvirt_virtproxyd_spec.rb index 4d100283a..9bba96ff2 100644 --- a/spec/classes/nova_compute_libvirt_virtproxyd_spec.rb +++ b/spec/classes/nova_compute_libvirt_virtproxyd_spec.rb @@ -18,19 +18,23 @@ describe 'nova::compute::libvirt::virtproxyd' do it { is_expected.to contain_virtproxyd_config('log_filters').with_value('').with_quote(true)} it { is_expected.to contain_virtproxyd_config('max_clients').with_value('')} it { is_expected.to contain_virtproxyd_config('admin_max_clients').with_value('')} + it { is_expected.to contain_virtproxyd_config('max_client_requests').with_value('')} + it { is_expected.to contain_virtproxyd_config('admin_max_client_requests').with_value('')} it { is_expected.to contain_virtproxyd_config('ovs_timeout').with_value('')} it { is_expected.to contain_virtproxyd_config('tls_priority').with_value('').with_quote(true)} end context 'with specified parameters' do let :params do - { :log_level => 3, - :log_outputs => '3:syslog', - :log_filters => '1:logging 4:object 4:json 4:event 1:util', - :max_clients => 1024, - :admin_max_clients => 5, - :ovs_timeout => 10, - :tls_priority => 'NORMAL:-VERS-SSL3.0', + { :log_level => 3, + :log_outputs => '3:syslog', + :log_filters => '1:logging 4:object 4:json 4:event 1:util', + :max_clients => 1024, + :admin_max_clients => 5, + :max_client_requests => 42, + :admin_max_client_requests => 55, + :ovs_timeout => 10, + :tls_priority => 'NORMAL:-VERS-SSL3.0', } end @@ -41,6 +45,8 @@ describe 'nova::compute::libvirt::virtproxyd' do it { is_expected.to contain_virtproxyd_config('log_filters').with_value(params[:log_filters]).with_quote(true)} it { is_expected.to contain_virtproxyd_config('max_clients').with_value(params[:max_clients])} it { is_expected.to contain_virtproxyd_config('admin_max_clients').with_value(params[:admin_max_clients])} + it { is_expected.to contain_virtproxyd_config('max_client_requests').with_value(params[:max_client_requests])} + it { is_expected.to contain_virtproxyd_config('admin_max_client_requests').with_value(params[:admin_max_client_requests])} it { is_expected.to contain_virtproxyd_config('ovs_timeout').with_value(params[:ovs_timeout])} it { is_expected.to contain_virtproxyd_config('tls_priority').with_value(params[:tls_priority]).with_quote(true)} end diff --git a/spec/classes/nova_compute_libvirt_virtqemud_spec.rb b/spec/classes/nova_compute_libvirt_virtqemud_spec.rb index 24b73a2ac..006b4b3f3 100644 --- a/spec/classes/nova_compute_libvirt_virtqemud_spec.rb +++ b/spec/classes/nova_compute_libvirt_virtqemud_spec.rb @@ -18,17 +18,21 @@ describe 'nova::compute::libvirt::virtqemud' do it { is_expected.to contain_virtqemud_config('log_filters').with_value('').with_quote(true)} it { is_expected.to contain_virtqemud_config('max_clients').with_value('')} it { is_expected.to contain_virtqemud_config('admin_max_clients').with_value('')} + it { is_expected.to contain_virtqemud_config('max_client_requests').with_value('')} + it { is_expected.to contain_virtqemud_config('admin_max_client_requests').with_value('')} it { is_expected.to contain_virtqemud_config('ovs_timeout').with_value('')} end context 'with specified parameters' do let :params do - { :log_level => 3, - :log_outputs => '3:syslog', - :log_filters => '1:logging 4:object 4:json 4:event 1:util', - :max_clients => 1024, - :admin_max_clients => 5, - :ovs_timeout => 10, + { :log_level => 3, + :log_outputs => '3:syslog', + :log_filters => '1:logging 4:object 4:json 4:event 1:util', + :max_clients => 1024, + :admin_max_clients => 5, + :max_client_requests => 42, + :admin_max_client_requests => 55, + :ovs_timeout => 10, } end @@ -39,6 +43,8 @@ describe 'nova::compute::libvirt::virtqemud' do it { is_expected.to contain_virtqemud_config('log_filters').with_value(params[:log_filters]).with_quote(true)} it { is_expected.to contain_virtqemud_config('max_clients').with_value(params[:max_clients])} it { is_expected.to contain_virtqemud_config('admin_max_clients').with_value(params[:admin_max_clients])} + it { is_expected.to contain_virtqemud_config('max_client_requests').with_value(params[:max_client_requests])} + it { is_expected.to contain_virtqemud_config('admin_max_client_requests').with_value(params[:admin_max_client_requests])} it { is_expected.to contain_virtqemud_config('ovs_timeout').with_value(params[:ovs_timeout])} end end diff --git a/spec/classes/nova_compute_libvirt_virtsecretd_spec.rb b/spec/classes/nova_compute_libvirt_virtsecretd_spec.rb index a195fc3d9..ee23905dc 100644 --- a/spec/classes/nova_compute_libvirt_virtsecretd_spec.rb +++ b/spec/classes/nova_compute_libvirt_virtsecretd_spec.rb @@ -18,17 +18,21 @@ describe 'nova::compute::libvirt::virtsecretd' do it { is_expected.to contain_virtsecretd_config('log_filters').with_value('').with_quote(true)} it { is_expected.to contain_virtsecretd_config('max_clients').with_value('')} it { is_expected.to contain_virtsecretd_config('admin_max_clients').with_value('')} + it { is_expected.to contain_virtsecretd_config('max_client_requests').with_value('')} + it { is_expected.to contain_virtsecretd_config('admin_max_client_requests').with_value('')} it { is_expected.to contain_virtsecretd_config('ovs_timeout').with_value('')} end context 'with specified parameters' do let :params do - { :log_level => 3, - :log_outputs => '3:syslog', - :log_filters => '1:logging 4:object 4:json 4:event 1:util', - :max_clients => 1024, - :admin_max_clients => 5, - :ovs_timeout => 10, + { :log_level => 3, + :log_outputs => '3:syslog', + :log_filters => '1:logging 4:object 4:json 4:event 1:util', + :max_clients => 1024, + :admin_max_clients => 5, + :max_client_requests => 42, + :admin_max_client_requests => 55, + :ovs_timeout => 10, } end @@ -39,6 +43,8 @@ describe 'nova::compute::libvirt::virtsecretd' do it { is_expected.to contain_virtsecretd_config('log_filters').with_value(params[:log_filters]).with_quote(true)} it { is_expected.to contain_virtsecretd_config('max_clients').with_value(params[:max_clients])} it { is_expected.to contain_virtsecretd_config('admin_max_clients').with_value(params[:admin_max_clients])} + it { is_expected.to contain_virtsecretd_config('max_client_requests').with_value(params[:max_client_requests])} + it { is_expected.to contain_virtsecretd_config('admin_max_client_requests').with_value(params[:admin_max_client_requests])} it { is_expected.to contain_virtsecretd_config('ovs_timeout').with_value(params[:ovs_timeout])} end end