openstack/puppet-nova
Code Issues Proposed changes

Do not test details of oslo::cache

Browse Source 
... but test interface of oslo::cache, to make these test cases robust
for any change in oslo::cache.

Change-Id: I63dbdf8d6295724bc1008ff06486d6de068af18c
This commit is contained in:
Takashi Kajinami
2021-08-23 14:06:44 +09:00
parent 371242b879
commit 488a03e51f
1 changed files with 47 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
spec/classes/nova_cache_spec.rb
View File

@@ -6,30 +6,31 @@ describe 'nova::cache' do
{} {}
end end
shared_examples_for 'nova-cache' do shared_examples_for 'nova::cache' do
context 'with default parameters' do context 'with default parameters' do
it 'configures cache' do it 'configures cache' do
is_expected.to contain_nova_config('cache/config_prefix').with_value('<SERVICE DEFAULT>') is_expected.to contain_oslo__cache('nova_config').with(
is_expected.to contain_nova_config('cache/expiration_time').with_value('<SERVICE DEFAULT>') :config_prefix => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/backend').with_value('<SERVICE DEFAULT>') :expiration_time => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/backend_argument').with_value('<SERVICE DEFAULT>') :backend => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/proxies').with_value('<SERVICE DEFAULT>') :backend_argument => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/enabled').with_value('<SERVICE DEFAULT>') :proxies => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/debug_cache_backend').with_value('<SERVICE DEFAULT>') :enabled => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_servers').with_value('<SERVICE DEFAULT>') :debug_cache_backend => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_dead_retry').with_value('<SERVICE DEFAULT>') :memcache_servers => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_socket_timeout').with_value('<SERVICE DEFAULT>') :memcache_dead_retry => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_pool_maxsize').with_value('<SERVICE DEFAULT>') :memcache_socket_timeout => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_pool_unused_timeout').with_value('<SERVICE DEFAULT>') :memcache_pool_maxsize => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/memcache_pool_connection_get_timeout').with_value('<SERVICE DEFAULT>') :memcache_pool_unused_timeout => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_enabled').with_value('<SERVICE DEFAULT>') :memcache_pool_connection_get_timeout => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_cafile').with_value('<SERVICE DEFAULT>') :tls_enabled => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_certfile').with_value('<SERVICE DEFAULT>') :tls_cafile => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_keyfile').with_value('<SERVICE DEFAULT>') :tls_certfile => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_allowed_ciphers').with_value('<SERVICE DEFAULT>') :tls_keyfile => '<SERVICE DEFAULT>',
:tls_allowed_ciphers => '<SERVICE DEFAULT>',
is_expected.to contain_oslo__cache('nova_config').with_manage_backend_package(true) :manage_backend_package => true,
)
end end
end end
@@ -37,7 +38,7 @@ describe 'nova::cache' do
let :params do let :params do
{ {
:config_prefix => 'prefix', :config_prefix => 'prefix',
:expiration_time => '3600', :expiration_time => 3600,
:backend => 'oslo_cache.memcache_pool', :backend => 'oslo_cache.memcache_pool',
:proxies => ['proxy01:8888', 'proxy02:8888'], :proxies => ['proxy01:8888', 'proxy02:8888'],
:enabled => true, :enabled => true,
@@ -48,36 +49,33 @@ describe 'nova::cache' do
:memcache_pool_maxsize => '10', :memcache_pool_maxsize => '10',
:memcache_pool_unused_timeout => '120', :memcache_pool_unused_timeout => '120',
:memcache_pool_connection_get_timeout => '360', :memcache_pool_connection_get_timeout => '360',
:manage_backend_package => false,
:tls_enabled => false, :tls_enabled => false,
:tls_cafile => nil, :manage_backend_package => false,
:tls_certfile => nil,
:tls_keyfile => nil,
:tls_allowed_ciphers => nil,
} }
end end
it 'configures cache' do it 'configures cache' do
is_expected.to contain_nova_config('cache/config_prefix').with_value('prefix') is_expected.to contain_oslo__cache('nova_config').with(
is_expected.to contain_nova_config('cache/expiration_time').with_value('3600') :config_prefix => 'prefix',
is_expected.to contain_nova_config('cache/backend').with_value('oslo_cache.memcache_pool') :expiration_time => 3600,
is_expected.to contain_nova_config('cache/backend_argument').with_value('<SERVICE DEFAULT>') :backend => 'oslo_cache.memcache_pool',
is_expected.to contain_nova_config('cache/proxies').with_value('proxy01:8888,proxy02:8888') :backend_argument => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/enabled').with_value('true') :proxies => ['proxy01:8888', 'proxy02:8888'],
is_expected.to contain_nova_config('cache/debug_cache_backend').with_value('false') :enabled => true,
is_expected.to contain_nova_config('cache/memcache_servers').with_value('memcached01:11211,memcached02:11211') :debug_cache_backend => false,
is_expected.to contain_nova_config('cache/memcache_dead_retry').with_value('60') :memcache_servers => ['memcached01:11211', 'memcached02:11211'],
is_expected.to contain_nova_config('cache/memcache_socket_timeout').with_value('300.0') :memcache_dead_retry => '60',
is_expected.to contain_nova_config('cache/memcache_pool_maxsize').with_value('10') :memcache_socket_timeout => '300.0',
is_expected.to contain_nova_config('cache/memcache_pool_unused_timeout').with_value('120') :memcache_pool_maxsize => '10',
is_expected.to contain_nova_config('cache/memcache_pool_connection_get_timeout').with_value('360') :memcache_pool_unused_timeout => '120',
is_expected.to contain_nova_config('cache/tls_enabled').with_value('false') :memcache_pool_connection_get_timeout => '360',
is_expected.to contain_nova_config('cache/tls_cafile').with_value('nil') :tls_enabled => false,
is_expected.to contain_nova_config('cache/tls_certfile').with_value('nil') :tls_cafile => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_keyfile').with_value('nil') :tls_certfile => '<SERVICE DEFAULT>',
is_expected.to contain_nova_config('cache/tls_allowed_ciphers').with_value('nil') :tls_keyfile => '<SERVICE DEFAULT>',
:tls_allowed_ciphers => '<SERVICE DEFAULT>',
is_expected.to contain_oslo__cache('nova_config').with_manage_backend_package(false) :manage_backend_package => false,
)
end end
end end
end end
@@ -90,7 +88,7 @@ describe 'nova::cache' do
facts.merge!(OSDefaults.get_facts()) facts.merge!(OSDefaults.get_facts())
end end
it_configures 'nova-cache' it_configures 'nova::cache'
end end
end end