From 4a4ac4a3cc038a7c3d5de934c54bc192e3474fdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Gagne=CC=81?= Date: Wed, 13 Jun 2018 17:48:46 -0400 Subject: [PATCH] Add aggregate metadata unset support to nova_aggregate Feature was waiting for python-openstackclient to add support for the "openstack aggregate unset" command. This is now available in 2.4.0. Closes-bug: #1776772 Change-Id: Id6ddd9d0a193819c9f69ea138554a2647bcd8ae3 --- lib/puppet/provider/nova_aggregate/openstack.rb | 15 +++++++-------- .../aggregate-unset-support-445c9a3794ca33d6.yaml | 5 +++++ 2 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 releasenotes/notes/aggregate-unset-support-445c9a3794ca33d6.yaml diff --git a/lib/puppet/provider/nova_aggregate/openstack.rb b/lib/puppet/provider/nova_aggregate/openstack.rb index c0c39ec4f..7d347f0aa 100644 --- a/lib/puppet/provider/nova_aggregate/openstack.rb +++ b/lib/puppet/provider/nova_aggregate/openstack.rb @@ -86,14 +86,13 @@ Puppet::Type.type(:nova_aggregate).provide( def metadata=(value) # clear obsolete keys - # wip until #1559866 -# if @property_hash[:metadata].keys.length > 0 -# properties = [@resource[:name] ] -# (@property_hash[:metadata].keys - @resource[:metadata].keys).each do |key| -# properties << "--property" << "#{key}" -# end -# self.class.request('aggregate', 'unset', properties) -# end + if @property_hash[:metadata].keys.length > 0 + properties = [@resource[:name] ] + (@property_hash[:metadata].keys - @resource[:metadata].keys).each do |key| + properties << "--property" << "#{key}" + end + self.class.request('aggregate', 'unset', properties) + end properties = [@resource[:name] ] @resource[:metadata].each do |key, value| properties << "--property" << "#{key}=#{value}" diff --git a/releasenotes/notes/aggregate-unset-support-445c9a3794ca33d6.yaml b/releasenotes/notes/aggregate-unset-support-445c9a3794ca33d6.yaml new file mode 100644 index 000000000..3e9f6c8f5 --- /dev/null +++ b/releasenotes/notes/aggregate-unset-support-445c9a3794ca33d6.yaml @@ -0,0 +1,5 @@ +--- +features: + - | + The nova_aggregate resource type can now unset aggregate metadata. + [Bug `1776772 `_]