Use new openstackclient tag

This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.

Also, novaclient is not required by nova itself so the support
package tag can be removed.

Depends-on: https://review.opendev.org/899594
Change-Id: I6c43e57251d1520bc7622f0135a12f2a5bebaa62

manifests/client.pp

@@ -20,7 +20,7 @@ in a future release.")
   package { 'python-novaclient':
     ensure => $ensure,
     name   => $::nova::params::client_package,
-    tag    => ['openstack', 'nova-support-package'],
+    tag    => 'openstack',
   }
 
 }

manifests/deps.pp

@@ -70,8 +70,8 @@ class nova::deps {
   # will have clients available to create resources. This tag handles the
   # openstackclient but indirectly since the client is not available in
   # all catalogs that don't need the client class (like many spec tests)
-  Package<| tag == 'openstack'|>
-  ~> Anchor['nova::service::end']
+  Package<| tag == 'openstackclient'|>
+  -> Anchor['nova::service::end']
 
   # Manage libvirt configurations during the config phase
   Anchor['nova::config::begin'] -> Libvirtd_config<||> -> Anchor['nova::config::end']

spec/classes/nova_client_spec.rb

@@ -11,7 +11,7 @@ describe 'nova::client' do
       is_expected.to contain_package('python-novaclient').with(
         :ensure => 'present',
         :name   => platform_params[:client_package_name],
-        :tag    => ['openstack', 'nova-support-package']
+        :tag    => 'openstack',
       )
     end
   end