openstack/puppet-nova
Code Issues Proposed changes

Add support for [libvirt] tb_cache_size

Browse Source 
Depends-on: https://review.opendev.org/c/openstack/nova/+/868419
Change-Id: If3c8d35a2f39bf14699deff8413f5f727bf4c5e3
This commit is contained in:
Takashi Kajinami 2023-08-04 14:01:39 +09:00
parent 7025f6e5b1
commit 4d5b87e7ad
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/compute/libvirt.pp
View File

@ -229,6 +229,10 @@
# reboot request is made. # reboot request is made.
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# #
# [*tb_cache_size*]
# (optional) The tb-cache size (in MiB) of each guest VM.
# Defaults to $facts['os_service_default']
#
class nova::compute::libvirt ( class nova::compute::libvirt (
$ensure_package = 'present', $ensure_package = 'present',
$virt_type = 'kvm', $virt_type = 'kvm',
@ -274,6 +278,7 @@ class nova::compute::libvirt (
$max_queues = $facts['os_service_default'], $max_queues = $facts['os_service_default'],
$num_memory_encrypted_guests = $facts['os_service_default'], $num_memory_encrypted_guests = $facts['os_service_default'],
$wait_soft_reboot_seconds = $facts['os_service_default'], $wait_soft_reboot_seconds = $facts['os_service_default'],
$tb_cache_size = $facts['os_service_default'],
) inherits nova::params { ) inherits nova::params {
include nova::deps include nova::deps
@ -376,6 +381,7 @@ class nova::compute::libvirt (
'libvirt/max_queues': value => $max_queues; 'libvirt/max_queues': value => $max_queues;
'libvirt/num_memory_encrypted_guests': value => $num_memory_encrypted_guests; 'libvirt/num_memory_encrypted_guests': value => $num_memory_encrypted_guests;
'libvirt/wait_soft_reboot_seconds': value => $wait_soft_reboot_seconds; 'libvirt/wait_soft_reboot_seconds': value => $wait_soft_reboot_seconds;
'libvirt/tb_cache_size': value => $tb_cache_size;
} }
# cpu_model param is only valid if cpu_mode=custom # cpu_model param is only valid if cpu_mode=custom

4
releasenotes/notes/tb_cache_size-68e4d02b579a4a50.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``nova::compute::libvirt::tb_cache_size`` parameter has been added.

3
spec/classes/nova_compute_libvirt_spec.rb
View File

@ -81,6 +81,7 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('libvirt/max_queues').with_value('<SERVICE DEFAULT>')} it { is_expected.to contain_nova_config('libvirt/max_queues').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/num_memory_encrypted_guests').with_value('<SERVICE DEFAULT>')} it { is_expected.to contain_nova_config('libvirt/num_memory_encrypted_guests').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/wait_soft_reboot_seconds').with_value('<SERVICE DEFAULT>')} it { is_expected.to contain_nova_config('libvirt/wait_soft_reboot_seconds').with_value('<SERVICE DEFAULT>')}
it { is_expected.to contain_nova_config('libvirt/tb_cache_size').with_value('<SERVICE DEFAULT>')}
end end
describe 'with params' do describe 'with params' do
@ -124,6 +125,7 @@ describe 'nova::compute::libvirt' do
:max_queues => 4, :max_queues => 4,
:num_memory_encrypted_guests => 255, :num_memory_encrypted_guests => 255,
:wait_soft_reboot_seconds => 120, :wait_soft_reboot_seconds => 120,
:tb_cache_size => 32,
} }
end end
@ -166,6 +168,7 @@ describe 'nova::compute::libvirt' do
it { is_expected.to contain_nova_config('libvirt/max_queues').with_value(4)} it { is_expected.to contain_nova_config('libvirt/max_queues').with_value(4)}
it { is_expected.to contain_nova_config('libvirt/num_memory_encrypted_guests').with_value(255)} it { is_expected.to contain_nova_config('libvirt/num_memory_encrypted_guests').with_value(255)}
it { is_expected.to contain_nova_config('libvirt/wait_soft_reboot_seconds').with_value(120)} it { is_expected.to contain_nova_config('libvirt/wait_soft_reboot_seconds').with_value(120)}
it { is_expected.to contain_nova_config('libvirt/tb_cache_size').with_value(32)}
it { it {
is_expected.to contain_service('libvirt').with( is_expected.to contain_service('libvirt').with(