openstack
/
puppet-nova
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(2 comments)

Hi Maik, thanks for this first contribution. The patch is good, only a few issues with your text editor that left spaces/tab in your commit. Once that fixed the patch will be good to me.

Patch-set: 1
Reviewer: Gerrit User 9410 <9410@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 9410 2014-11-15 21:28:59 +00:00 committed by Gerrit Code Review
parent 5213e2725c
commit 4f8881d794
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
b13ebb2e6a8b6c6a2b3cfc860f93982d21a01673 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "5a890539_7b6058a5",
"filename": "spec/classes/nova_compute_libvirt_spec.rb",
"patchSetId": 1
},
"lineNbr": 54,
"author": {
"id": 9410
},
"writtenOn": "2014-11-15T21:28:59Z",
"side": 1,
"message": "Warning: Text editor issue ? Extra tabs",
"revId": "b13ebb2e6a8b6c6a2b3cfc860f93982d21a01673",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a890539_9b6504b7",
"filename": "spec/classes/nova_compute_libvirt_spec.rb",
"patchSetId": 1
},
"lineNbr": 67,
"author": {
"id": 9410
},
"writtenOn": "2014-11-15T21:28:59Z",
"side": 1,
"message": "ditto",
"revId": "b13ebb2e6a8b6c6a2b3cfc860f93982d21a01673",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}