From 5f6184aea98e16ead88fbd3a400730cdb391f9e4 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <kajinamit@oss.nttdata.com>
Date: Sat, 12 Oct 2024 01:23:40 +0900
Subject: [PATCH] Expose configure_service

This parameter has been implemented in the underlying defined resource
type but was not configurable.

Change-Id: I6de5384c7d5085aeca212d7aee444b6ac4266a58
---
 manifests/keystone/auth.pp                                 | 6 ++++++
 releasenotes/notes/configure_service-2e5f1ad74f9adbdc.yaml | 5 +++++
 spec/classes/nova_keystone_auth_spec.rb                    | 3 +++
 3 files changed, 14 insertions(+)
 create mode 100644 releasenotes/notes/configure_service-2e5f1ad74f9adbdc.yaml

diff --git a/manifests/keystone/auth.pp b/manifests/keystone/auth.pp
index 0613aca2e..dbfe42bab 100644
--- a/manifests/keystone/auth.pp
+++ b/manifests/keystone/auth.pp
@@ -71,6 +71,10 @@
 #   (Optional) Whether to configure the admin role for the service user.
 #   Defaults to true
 #
+# [*configure_service*]
+#   (Optional) Should the service be configurd?
+#   Defaults to True
+#
 class nova::keystone::auth(
   String[1] $password,
   String[1] $auth_name                    = 'nova',
@@ -89,6 +93,7 @@ class nova::keystone::auth(
   Boolean $configure_endpoint             = true,
   Boolean $configure_user                 = true,
   Boolean $configure_user_role            = true,
+  Boolean $configure_service              = true,
 ) {
 
   include nova::deps
@@ -99,6 +104,7 @@ class nova::keystone::auth(
     configure_user      => $configure_user,
     configure_user_role => $configure_user_role,
     configure_endpoint  => $configure_endpoint,
+    configure_service   => $configure_service,
     service_type        => $service_type,
     service_description => $service_description,
     service_name        => $service_name,
diff --git a/releasenotes/notes/configure_service-2e5f1ad74f9adbdc.yaml b/releasenotes/notes/configure_service-2e5f1ad74f9adbdc.yaml
new file mode 100644
index 000000000..d1e465560
--- /dev/null
+++ b/releasenotes/notes/configure_service-2e5f1ad74f9adbdc.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    The new ``nova::keystone::auth::configure_service`` parameter has been
+    added.
diff --git a/spec/classes/nova_keystone_auth_spec.rb b/spec/classes/nova_keystone_auth_spec.rb
index 7c195193b..1564e14b4 100644
--- a/spec/classes/nova_keystone_auth_spec.rb
+++ b/spec/classes/nova_keystone_auth_spec.rb
@@ -15,6 +15,7 @@ describe 'nova::keystone::auth' do
         :configure_user      => true,
         :configure_user_role => true,
         :configure_endpoint  => true,
+        :configure_service   => true,
         :service_name        => 'nova',
         :service_type        => 'compute',
         :service_description => 'OpenStack Compute Service',
@@ -41,6 +42,7 @@ describe 'nova::keystone::auth' do
           :configure_endpoint  => false,
           :configure_user      => false,
           :configure_user_role => false,
+          :configure_service   => false,
           :service_description => 'Alternative OpenStack Compute Service',
           :service_name        => 'alt_service',
           :service_type        => 'alt_compute',
@@ -57,6 +59,7 @@ describe 'nova::keystone::auth' do
         :configure_user      => false,
         :configure_user_role => false,
         :configure_endpoint  => false,
+        :configure_service   => false,
         :service_name        => 'alt_service',
         :service_type        => 'alt_compute',
         :service_description => 'Alternative OpenStack Compute Service',