From 70bb80f6d33a4c81a370cd051a4a47c5a2b2c88c Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Sun, 13 Mar 2022 21:31:14 +0900
Subject: [PATCH] Deprecate support for novajoin

... because novajoin[1] repo is unmaintained. Its code has not been
updated for last 2 years. It's CI has been broken for several months.
Also, it only supports Python 3.6 and doesn't support 3.7, 3.8 or 3.9.

In the past we used novajoin in TripleO to enable TLS for internal
communications but that usage was already deprecated[2].

[1] https://opendev.org/x/novajoin
[2] bf910512c344f55d01303409f6c2151d89347583

Change-Id: Ia8a45480aad3510a14c475b4b003b22bca6a115b
---
 manifests/metadata/novajoin/api.pp                          | 3 +++
 manifests/metadata/novajoin/auth.pp                         | 2 ++
 manifests/metadata/novajoin/authtoken.pp                    | 2 ++
 manifests/metadata/novajoin/policy.pp                       | 2 ++
 releasenotes/notes/deprecate-novajoin-c602cca8f07083cc.yaml | 5 +++++
 5 files changed, 14 insertions(+)
 create mode 100644 releasenotes/notes/deprecate-novajoin-c602cca8f07083cc.yaml

diff --git a/manifests/metadata/novajoin/api.pp b/manifests/metadata/novajoin/api.pp
index 8e91787fc..539333e2b 100644
--- a/manifests/metadata/novajoin/api.pp
+++ b/manifests/metadata/novajoin/api.pp
@@ -1,5 +1,6 @@
 # == Class: nova::metadata::novajoin::api
 #
+# DEPRECATED !
 # The nova::metadata::novajoin::api class encapsulates an
 # IPA Nova Join API service.
 #
@@ -127,6 +128,8 @@ class nova::metadata::novajoin::api (
   $configure_kerberos        = false,
   $ipa_realm                 = undef,
 ) {
+  warning('Support for novajoin service is deprecated!')
+
   include nova::params
   include nova::metadata::novajoin::authtoken
   include nova::metadata::novajoin::policy
diff --git a/manifests/metadata/novajoin/auth.pp b/manifests/metadata/novajoin/auth.pp
index 388b422d1..b9501c704 100644
--- a/manifests/metadata/novajoin/auth.pp
+++ b/manifests/metadata/novajoin/auth.pp
@@ -1,5 +1,6 @@
 # == Class: nova::metadata::novajoin::auth
 #
+# DEPRECATED !
 # Creates nova endpoints and service account in keystone
 #
 # === Parameters:
@@ -90,6 +91,7 @@ class nova::metadata::novajoin::auth(
   $configure_user          = true,
   $configure_user_role     = true,
 ) {
+  warning('Support for novajoin service is deprecated!')
 
   Keystone::Resource::Service_identity['novajoin'] -> Service <| name == 'novajoin-server' |>
 
diff --git a/manifests/metadata/novajoin/authtoken.pp b/manifests/metadata/novajoin/authtoken.pp
index a09e9ccba..0c2b89f35 100644
--- a/manifests/metadata/novajoin/authtoken.pp
+++ b/manifests/metadata/novajoin/authtoken.pp
@@ -1,5 +1,6 @@
 # class: nova::metadata::novajoin::authtoken
 #
+# DEPRECATED !
 # Configure the keystone_authtoken section in the configuration file
 #
 # === Parameters
@@ -235,6 +236,7 @@ class nova::metadata::novajoin::authtoken(
   $interface                      = $::os_service_default,
   $params                         = {},
 ) {
+  warning('Support for novajoin service is deprecated!')
 
   include nova::deps
 
diff --git a/manifests/metadata/novajoin/policy.pp b/manifests/metadata/novajoin/policy.pp
index 7a14d3713..6595dae54 100644
--- a/manifests/metadata/novajoin/policy.pp
+++ b/manifests/metadata/novajoin/policy.pp
@@ -1,5 +1,6 @@
 # == Class: nova::metadata::novajoin::policy
 #
+# DEPRECATED !
 # Configure the nova policies
 #
 # === Parameters
@@ -29,6 +30,7 @@ class nova::metadata::novajoin::policy (
   $policy_path  = '/etc/novajoin/policy.yaml',
   $purge_config = false,
 ) {
+  warning('Support for novajoin service is deprecated!')
 
   validate_legacy(Hash, 'validate_hash', $policies)
 
diff --git a/releasenotes/notes/deprecate-novajoin-c602cca8f07083cc.yaml b/releasenotes/notes/deprecate-novajoin-c602cca8f07083cc.yaml
new file mode 100644
index 000000000..1ace8805c
--- /dev/null
+++ b/releasenotes/notes/deprecate-novajoin-c602cca8f07083cc.yaml
@@ -0,0 +1,5 @@
+---
+deprecations:
+  - |
+    Support for novajoin service has been deprecated and will be removed in
+    a future release.