openstack
/
puppet-nova
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(1 comment)

Patch-set: 6
Reviewer: Gerrit User 9410 <9410@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 9410 2014-12-15 10:47:09 +00:00 committed by Gerrit Code Review
parent 8413a6f63b
commit 729b8ef48a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ff057aefbab2a6393fee30997d290e486fa15d65 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3a961159_109e1663",
"filename": "manifests/migration/libvirt.pp",
"patchSetId": 6
},
"lineNbr": 9,
"author": {
"id": 9410
},
"writtenOn": "2014-12-15T10:47:09Z",
"side": 1,
"message": "The use of augeas here seems unecessary, you could use file_line as the whole file does with the following structure\n\nfile_line { \u0027test\u0027 :\n path \u003d\u003e \u0027/etc/libvirt/libvirtd.conf\u0027,\n line \u003d\u003e \"host_uuid \u003d ${host_uuid}\",\n match \u003d\u003e \u0027^(#)?host_uuid \u003d \u0027,\n}",
"revId": "ff057aefbab2a6393fee30997d290e486fa15d65",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}