openstack
/
puppet-nova
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: Ibe827d6f40bfa6a0015a69d467c898f982cf9480
This commit is contained in:
Takashi Kajinami 2020-08-31 19:26:05 +09:00
parent f493b550f2
commit 77ed829265
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
manifests/db.pp
View File

@ -96,7 +96,6 @@ class nova::db (
) {
include nova::deps
include nova::params
if $::nova::database_min_pool_size or $database_min_pool_size {
warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.')
@ -115,10 +114,6 @@ class nova::db (
$database_max_overflow_real = pick($::nova::database_max_overflow, $database_max_overflow)
if !is_service_default($database_connection_real) {
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'nova_config':
db_max_retries => $database_db_max_retries,
connection => $database_connection_real,