openstack/puppet-nova
Code Issues Proposed changes

Remove listen option

Browse Source 
The previously deprecated config option ``listen```of the group
``serial_console`` has been removed, as it was never used in the code.

Change-Id: If2acdf6d40a7bfa3b1c33c9956c30f9a3a3e9e8e
This commit is contained in:
ZhongShengping
2016-11-02 10:52:53 +08:00
parent f02e416469
commit 8267730a90
2 changed files with 8 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
manifests/compute/serial.pp
View File

@@ -17,33 +17,18 @@
# should connect (string value) # should connect (string value)
# Defaults to 127.0.0.1 # Defaults to 127.0.0.1
# #
# DEPRECATED PARAMETERS
# [*listen*]
# This option has no effect anymore. Please use "proxyclient_address" instead
# This option is deprecated and will be removed in future releases
# Defaults to undef
#
class nova::compute::serial( class nova::compute::serial(
$port_range = '10000:20000', $port_range = '10000:20000',
$base_url = 'ws://127.0.0.1:6083/', $base_url = 'ws://127.0.0.1:6083/',
$proxyclient_address = '127.0.0.1', $proxyclient_address = '127.0.0.1',
# DEPRECATED PARAMETERS
$listen = undef,
) { ) {
include ::nova::deps include ::nova::deps
if $listen {
warning('The listen parameter has no effect anymore, please use proxyclient_address instead.')
$proxyclient_address_real = $listen
} else {
$proxyclient_address_real = $proxyclient_address
}
nova_config { nova_config {
'serial_console/enabled': value => true; 'serial_console/enabled': value => true;
'serial_console/port_range': value => $port_range; 'serial_console/port_range': value => $port_range;
'serial_console/base_url': value => $base_url; 'serial_console/base_url': value => $base_url;
'serial_console/proxyclient_address': value => $proxyclient_address_real; 'serial_console/proxyclient_address': value => $proxyclient_address;
} }
} }

4
releasenotes/notes/remove_deprecated_serial_console_listen_option-23a962e6f32861d3.yaml Normal file
View File

@@ -0,0 +1,4 @@
---
deprecations:
- The previously deprecated config option ``listen```of the group
``serial_console`` has been removed.