openstack
/
puppet-nova
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-2

(1 comment)

Thank you for your first contribution.
Please read comment inline.

Patch-set: 2
Reviewer: Gerrit User 3153 <3153@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-2
This commit is contained in:
Gerrit User 3153 2014-11-18 01:27:54 +00:00 committed by Gerrit Code Review
parent 6c3af50c87
commit 859ad79a86
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
cd9f08cfccdaf7cae0032c118ded63cf07230ea4 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "5a890539_a87a4785",
"filename": "manifests/compute/libvirt.pp",
"patchSetId": 2
},
"lineNbr": 34,
"author": {
"id": 3153
},
"writtenOn": "2014-11-18T01:27:54Z",
"side": 1,
"message": "This option is deprecated in Juno and will be removed in Kilo release.\nAlso, you set by default an empty list which is not the default in Nova upstream and you may break deployments.\nI guess you need this option in your Icehouse deployment, for this I would suggest to use nova_config provider in your manifests with this option because we are targetting Juno for now.",
"revId": "cd9f08cfccdaf7cae0032c118ded63cf07230ea4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}