From 9fe9b56aebe01f2e043363c8df8394713602005b Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 22 Sep 2017 18:04:53 -0400 Subject: [PATCH] Change Nova Conductor workers to ::os_workers In Ieb69b5a6a50d37b0a49a8c9e57275673d60b5f10, the default number of workers for the metadata_workers and osapi_compute_workers was changed from $::processorcount to $::os_workers, which takes CPU count into account but caps the number of workers for machines with high numbers of CPUs. The "workers" configuration option used by Nova Conductor however was left out of this, likely because it did not previously default to $::processorcount. However Nova itself defaults all of these services to the processor count in any case, and the number of workers for Conductor is likely the most critical value to be limited, since it directly corresponds to pooled database connections which when there are too many processes results in often thousands of connections that are almost all unused. This patch limits Conductor workers in the same way as that of the other worker counts. Change-Id: I1969b555c1c8cfb686a12cad7f54ac10b1656af5 --- manifests/conductor.pp | 4 ++-- releasenotes/notes/cap_workers-586a6d2168ddabca.yaml | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/cap_workers-586a6d2168ddabca.yaml diff --git a/manifests/conductor.pp b/manifests/conductor.pp index 822622e7a..9cf00c9fc 100644 --- a/manifests/conductor.pp +++ b/manifests/conductor.pp @@ -18,7 +18,7 @@ # # [*workers*] # (optional) Number of workers for OpenStack Conductor service -# Defaults to undef (i.e. parameter will not be present) +# Defaults to $::os_workers # # [*enable_new_services*] # (optional) When a new service (for example "nova-compute") start up, it gets @@ -37,7 +37,7 @@ class nova::conductor( $enabled = true, $manage_service = true, $ensure_package = 'present', - $workers = undef, + $workers = $::os_workers, $enable_new_services = $::os_service_default, # DEPREACTED PARAMETERS $use_local = undef, diff --git a/releasenotes/notes/cap_workers-586a6d2168ddabca.yaml b/releasenotes/notes/cap_workers-586a6d2168ddabca.yaml new file mode 100644 index 000000000..e5b63b68e --- /dev/null +++ b/releasenotes/notes/cap_workers-586a6d2168ddabca.yaml @@ -0,0 +1,6 @@ +--- +other: + - Added Nova Conductor service to the list of services where + the default number of spawned child processes for + distributing processing have had their default value changed from + ::processorcount to ::os_workers.