From b42ce7c3c46eef4ecd0ce26d0c74c9dd272e282a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mathieu=20Gagne=CC=81?= <mgagne@iweb.com>
Date: Thu, 30 Jan 2014 17:54:10 -0500
Subject: [PATCH] Cleanup rspec tests of nova::scheduler

Change-Id: Ie072c21606dd509bf64d764f6efd3ebabe9f857a
---
 spec/classes/nova_scheduler_spec.rb | 52 ++++++++---------------------
 1 file changed, 13 insertions(+), 39 deletions(-)

diff --git a/spec/classes/nova_scheduler_spec.rb b/spec/classes/nova_scheduler_spec.rb
index dce6d1dd0..1d46b2763 100644
--- a/spec/classes/nova_scheduler_spec.rb
+++ b/spec/classes/nova_scheduler_spec.rb
@@ -6,51 +6,25 @@ describe 'nova::scheduler' do
     'include nova'
   end
 
-  describe 'on debian platforms' do
+  context 'on Debian platforms' do
     let :facts do
       { :osfamily => 'Debian' }
     end
-    it { should contain_service('nova-scheduler').with(
-      'name'      => 'nova-scheduler',
-      'ensure'    => 'stopped',
-      'hasstatus' => true,
-      'enable'    => false
-    )}
-    it { should contain_package('nova-scheduler').with(
-      'name'   => 'nova-scheduler',
-      'ensure' => 'present',
-      'notify' => 'Service[nova-scheduler]'
-    ) }
-    describe 'with enabled as true' do
-      let :params do
-        {:enabled => true}
-      end
-    it { should contain_service('nova-scheduler').with(
-      'name'      => 'nova-scheduler',
-      'ensure'    => 'running',
-      'hasstatus' => true,
-      'enable'    => true
-    )}
-    end
-    describe 'with package version' do
-      let :params do
-        {:ensure_package => '2012.1-2'}
-      end
-      it { should contain_package('nova-scheduler').with(
-        'ensure' => '2012.1-2'
-      )}
-    end
+
+    it_behaves_like 'generic nova service', {
+      :name         => 'nova-scheduler',
+      :package_name => 'nova-scheduler',
+      :service_name => 'nova-scheduler' }
   end
-  describe 'on rhel' do
+
+  context 'on RedHat platforms' do
     let :facts do
       { :osfamily => 'RedHat' }
     end
-    it { should contain_service('nova-scheduler').with(
-      'name'      => 'openstack-nova-scheduler',
-      'ensure'    => 'stopped',
-      'hasstatus' => true,
-      'enable'    => false
-    )}
-    it { should contain_package('nova-scheduler').with_name('openstack-nova-scheduler') }
+
+    it_behaves_like 'generic nova service', {
+      :name         => 'nova-scheduler',
+      :package_name => 'openstack-nova-scheduler',
+      :service_name => 'openstack-nova-scheduler' }
   end
 end