openstack
/
puppet-nova
Code Issues Proposed changes

Remove ineffective support for [scheduler] periodic_task_interval 

This parameter was deprecated during Xena cycle[1] and has had no
effect since then.

[1] 3375efcfd4

Change-Id: I36227d92bbbc64a4d3d756088ca57c8a6148d270
This commit is contained in:
Takashi Kajinami 2022-04-19 08:03:27 +09:00
parent a8d00ff718
commit bcfca7a4dd
3 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
manifests/scheduler.pp
View File

@ -68,12 +68,6 @@
#
# DEPRECATED PARAMETERS
#
# [*periodic_task_interval*]
# (Optional) This value controls how often (in seconds) to run periodic tasks
# in the scheduler. The specific tasks that are run for each period are
# determined by the particular scheduler being used.
# Defaults to undef
#
# [*query_placement_for_availability_zone*]
# (Optional) This setting allows the scheduler to look up a host aggregate
# with metadata key of availability zone set to the value provided by
@ -95,7 +89,6 @@ class nova::scheduler(
$enable_isolated_aggregate_filtering = $::os_service_default,
$query_placement_for_routed_network_aggregates = $::os_service_default,
# DEPRECATED PARAMETERS
$periodic_task_interval = undef,
$query_placement_for_availability_zone = undef,
) {
@ -104,10 +97,6 @@ class nova::scheduler(
include nova::params
include nova::availability_zone
if $periodic_task_interval != undef {
warning('The periodic_task_interval parameter is depreated and has no effect')
}
if $query_placement_for_availability_zone != undef {
warning('The query_placement_for_availability_zone parameter is deprecated.')
}
@ -133,8 +122,4 @@ class nova::scheduler(
'scheduler/query_placement_for_availability_zone': value => $query_placement_for_availability_zone_real;
'scheduler/query_placement_for_routed_network_aggregates': value => $query_placement_for_routed_network_aggregates;
}
nova_config {
'scheduler/periodic_task_interval': ensure => absent;
}
}

4
releasenotes/notes/remove-scheduler-periodic_task_interval-249e0a76423582f5.yaml Normal file
View File

@ -0,0 +1,4 @@
---
upgrade:
- |
The ``nova::scheduler::periodic_task_interval`` parameter has been removed.

1
spec/classes/nova_scheduler_spec.rb
View File

@ -19,7 +19,6 @@ describe 'nova::scheduler' do
it { is_expected.to contain_nova_config('scheduler/workers').with_value(4) }
it { is_expected.to contain_nova_config('scheduler/max_attempts').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('scheduler/periodic_task_interval').with_ensure('absent') }
it { is_expected.to contain_nova_config('scheduler/discover_hosts_in_cells_interval').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('scheduler/query_placement_for_image_type_support').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_nova_config('scheduler/limit_tenants_to_placement_aggregate').with_value('<SERVICE DEFAULT>') }