diff --git a/manifests/logging.pp b/manifests/logging.pp index 23975fb52..961768cbe 100644 --- a/manifests/logging.pp +++ b/manifests/logging.pp @@ -33,6 +33,10 @@ # If set to $::os_service_default, it will not log to any directory. # Defaults to '/var/log/nova' # +# [*log_file*] +# (Optional) File where logs should be stored. +# Defaults to $::os_service_default +# # [*logging_context_format_string*] # (Optional) Format string to use for log messages with context. # Defaults to $::os_service_default @@ -100,6 +104,7 @@ class nova::logging( $use_stderr = $::os_service_default, $log_facility = $::os_service_default, $log_dir = '/var/log/nova', + $log_file = $::os_service_default, $debug = $::os_service_default, $logging_context_format_string = $::os_service_default, $logging_default_format_string = $::os_service_default, @@ -134,6 +139,7 @@ class nova::logging( use_json => $use_json, use_journal => $use_journal, log_dir => $log_dir, + log_file => $log_file, syslog_log_facility => $log_facility, logging_context_format_string => $logging_context_format_string, logging_default_format_string => $logging_default_format_string, diff --git a/releasenotes/notes/add-log_file-for-logging-ab53c751b895dc0d.yaml b/releasenotes/notes/add-log_file-for-logging-ab53c751b895dc0d.yaml new file mode 100644 index 000000000..e40d4c813 --- /dev/null +++ b/releasenotes/notes/add-log_file-for-logging-ab53c751b895dc0d.yaml @@ -0,0 +1,4 @@ +--- +features: + - | + Add the log_file option for logging. diff --git a/spec/classes/nova_logging_spec.rb b/spec/classes/nova_logging_spec.rb index 87c3f53ba..f8bb73eda 100644 --- a/spec/classes/nova_logging_spec.rb +++ b/spec/classes/nova_logging_spec.rb @@ -29,6 +29,7 @@ describe 'nova::logging' do :use_stderr => false, :log_facility => 'LOG_FOO', :log_dir => '/var/log/foo', + :log_file => '/var/log/foo/nova.log', :debug => true, } end @@ -63,6 +64,7 @@ describe 'nova::logging' do :use_journal => '', :use_stderr => '', :log_dir => '/var/log/nova', + :log_file => '', :debug => '', ) is_expected.to contain_file('/var/log/nova/nova-manage.log').with( @@ -80,6 +82,7 @@ describe 'nova::logging' do :use_stderr => false, :syslog_log_facility => 'LOG_FOO', :log_dir => '/var/log/foo', + :log_file => '/var/log/foo/nova.log', :debug => true, ) is_expected.to contain_file('/var/log/foo/nova-manage.log').with(