openstack/puppet-nova
Code Issues Proposed changes

Cleanup rspec tests of nova::objectstore

Browse Source 
Change-Id: If97f057248d863077b5791af70342b75ec7d1b62
This commit is contained in:
Mathieu Gagné 2014-01-30 17:56:30 -05:00
parent b42ce7c3c4
commit c41567b147
1 changed files with 13 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
spec/classes/nova_objectstore_spec.rb
View File

@ -6,51 +6,25 @@ describe 'nova::objectstore' do
'include nova'
end
describe 'on debian platforms' do
context 'on Debian platforms' do
let :facts do
{ :osfamily => 'Debian' }
end
it { should contain_service('nova-objectstore').with(
'name' => 'nova-objectstore',
'ensure' => 'stopped',
'hasstatus' => true,
'enable' => false
)}
it { should contain_package('nova-objectstore').with(
'name' => 'nova-objectstore',
'ensure' => 'present',
'notify' => 'Service[nova-objectstore]'
) }
describe 'with enabled as true' do
let :params do
{:enabled => true}
end
it { should contain_service('nova-objectstore').with(
'name' => 'nova-objectstore',
'ensure' => 'running',
'hasstatus' => true,
'enable' => true
)}
end
describe 'with package version' do
let :params do
{:ensure_package => '2012.1-2'}
end
it { should contain_package('nova-objectstore').with(
'ensure' => '2012.1-2'
)}
end
it_behaves_like 'generic nova service', {
:name => 'nova-objectstore',
:package_name => 'nova-objectstore',
:service_name => 'nova-objectstore' }
end
describe 'on rhel' do
context 'on RedHat platforms' do
let :facts do
{ :osfamily => 'RedHat' }
end
it { should contain_service('nova-objectstore').with(
'name' => 'openstack-nova-objectstore',
'ensure' => 'stopped',
'hasstatus' => true,
'enable' => false
)}
it { should contain_package('nova-objectstore').with_name('openstack-nova-objectstore') }
it_behaves_like 'generic nova service', {
:name => 'nova-objectstore',
:package_name => 'openstack-nova-objectstore',
:service_name => 'openstack-nova-objectstore' }
end
end