openstack/puppet-nova
Code Issues Proposed changes

Fix duplicated and overwritten user keys

Browse Source 
spec/classes/nova_cron_archive_deleted_rows_spec.rb:24:
warning: key :user is duplicated and overwritten on line 26
spec/classes/nova_cron_archive_deleted_rows_spec.rb:47:
warning: key :user is duplicated and overwritten on line 49
spec/classes/nova_cron_archive_deleted_rows_spec.rb:70:
warning: key :user is duplicated and overwritten on line 72
spec/classes/nova_cron_archive_deleted_rows_spec.rb:94:
warning: key :user is duplicated and overwritten on line 96

Change-Id: Iec772237b093c89fc24ed4b6e9d37429331b4788
This commit is contained in:
Tobias Urdin 2018-11-20 01:33:49 +01:00
parent aea8506c0a
commit c7f44fde73
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spec/classes/nova_cron_archive_deleted_rows_spec.rb
View File

@ -21,7 +21,6 @@ describe 'nova::cron::archive_deleted_rows' do
it 'configures a cron without until_complete' do
is_expected.to contain_cron('nova-manage db archive_deleted_rows').with(
:command => "nova-manage db archive_deleted_rows --max_rows #{params[:max_rows]} >>#{params[:destination]} 2>&1",
:user => 'nova',
:environment => 'PATH=/bin:/usr/bin:/usr/sbin SHELL=/bin/sh',
:user => params[:user],
:minute => params[:minute],
@ -44,7 +43,6 @@ describe 'nova::cron::archive_deleted_rows' do
it 'configures a cron with until_complete' do
is_expected.to contain_cron('nova-manage db archive_deleted_rows').with(
:command => "nova-manage db archive_deleted_rows --max_rows #{params[:max_rows]} --until-complete >>#{params[:destination]} 2>&1",
:user => 'nova',
:environment => 'PATH=/bin:/usr/bin:/usr/sbin SHELL=/bin/sh',
:user => params[:user],
:minute => params[:minute],
@ -67,7 +65,6 @@ describe 'nova::cron::archive_deleted_rows' do
it 'configures a cron with purge' do
is_expected.to contain_cron('nova-manage db archive_deleted_rows').with(
:command => "nova-manage db archive_deleted_rows --purge --max_rows #{params[:max_rows]} >>#{params[:destination]} 2>&1",
:user => 'nova',
:environment => 'PATH=/bin:/usr/bin:/usr/sbin SHELL=/bin/sh',
:user => params[:user],
:minute => params[:minute],
@ -91,7 +88,6 @@ describe 'nova::cron::archive_deleted_rows' do
it 'configures a cron with all purge params' do
is_expected.to contain_cron('nova-manage db archive_deleted_rows').with(
:command => "nova-manage db archive_deleted_rows --purge --max_rows #{params[:max_rows]} --until-complete >>#{params[:destination]} 2>&1",
:user => 'nova',
:environment => 'PATH=/bin:/usr/bin:/usr/sbin SHELL=/bin/sh',
:user => params[:user],
:minute => params[:minute],