openstack/puppet-nova
Code Issues Proposed changes

Stop hard-coding default of allow_resize_to_same_host

Browse Source 
The value currently defined in the class matches the service default
value so we can safely remove that hard-coding.

Change-Id: I998879531dd4b5792ca9674f91b555f349ca3ca7
This commit is contained in:
Takashi Kajinami
2023-05-26 11:06:18 +09:00
parent 5fe2ca84b0
commit d1bd167ddd
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/api.pp
View File

@@ -125,7 +125,7 @@
#
# [*allow_resize_to_same_host*]
# (optional) Allow destination machine to match source for resize.
# Defaults to false
# Defaults to $facts['os_service_default']
#
# [*instance_list_per_project_cells*]
# (optional) Only query cell databases in which the tenant has mapped
@@ -187,7 +187,7 @@ class nova::api(
$enable_network_quota = $facts['os_service_default'],
$enable_instance_password = $facts['os_service_default'],
$password_length = $facts['os_service_default'],
$allow_resize_to_same_host = false,
$allow_resize_to_same_host = $facts['os_service_default'],
$instance_list_per_project_cells = $facts['os_service_default'],
$instance_list_cells_batch_strategy = $facts['os_service_default'],
$instance_list_cells_batch_fixed_size = $facts['os_service_default'],

2
spec/classes/nova_api_spec.rb
View File

@@ -65,7 +65,7 @@ describe 'nova::api' do
is_expected.to contain_nova_config('DEFAULT/enable_network_quota').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('api/enable_instance_password').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/password_length').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('DEFAULT/allow_resize_to_same_host').with_value(false)
is_expected.to contain_nova_config('DEFAULT/allow_resize_to_same_host').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('api/instance_list_per_project_cells').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('api/instance_list_cells_batch_strategy').with_value('<SERVICE DEFAULT>')
is_expected.to contain_nova_config('api/instance_list_cells_batch_fixed_size').with_value('<SERVICE DEFAULT>')