openstack/puppet-nova
Code Issues Proposed changes

set required parameters

Browse Source 
A few additional params are now required. This commit sets them
so that the tests pass.
This commit is contained in:
Dan Bode 2012-10-14 14:26:25 -07:00
parent 29e06293c2
commit fc30821d4e
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/classes/nova_api_spec.rb
View File

@ -6,6 +6,10 @@ describe 'nova::api' do
'include nova' 'include nova'
end end
let :params do
{:admin_password => 'passw0rd'}
end
describe 'on debian platforms' do describe 'on debian platforms' do
let :facts do let :facts do
{ :osfamily => 'Debian' } { :osfamily => 'Debian' }
@ -22,7 +26,7 @@ describe 'nova::api' do
) } ) }
describe 'with enabled as true' do describe 'with enabled as true' do
let :params do let :params do
{:enabled => true} {:admin_password => 'passw0rd', :enabled => true}
end end
it { should contain_service('nova-api').with( it { should contain_service('nova-api').with(
'name' => 'nova-api', 'name' => 'nova-api',
@ -32,7 +36,7 @@ describe 'nova::api' do
end end
describe 'with package version' do describe 'with package version' do
let :params do let :params do
{:ensure_package => '2012.1-2'} {:admin_password => 'passw0rd', :ensure_package => '2012.1-2'}
end end
it { should contain_package('nova-api').with( it { should contain_package('nova-api').with(
'ensure' => '2012.1-2' 'ensure' => '2012.1-2'

7
spec/classes/nova_keystone_endpoint_spec.rb
View File

@ -4,6 +4,10 @@ describe 'nova::keystone::auth' do
describe 'with defaults' do describe 'with defaults' do
let :params do
{:password => 'nova_password'}
end
it { should contain_keystone_user('nova').with( it { should contain_keystone_user('nova').with(
:ensure => 'present', :ensure => 'present',
:password => 'nova_password' :password => 'nova_password'
@ -61,7 +65,7 @@ describe 'nova::keystone::auth' do
describe 'when setting auth name' do describe 'when setting auth name' do
let :params do let :params do
{:auth_name => 'foo' } {:password => 'nova_password', :auth_name => 'foo' }
end end
it { should contain_keystone_user('foo').with( it { should contain_keystone_user('foo').with(
@ -112,6 +116,7 @@ describe 'nova::keystone::auth' do
let :params do let :params do
{ {
:password => 'nova_password',
:public_address => '10.0.0.1', :public_address => '10.0.0.1',
:admin_address => '10.0.0.2', :admin_address => '10.0.0.2',
:internal_address => '10.0.0.3', :internal_address => '10.0.0.3',