This change ensures the following parameters are purged by default.
[spice] html5proxy_base_url
[spice] server_listen
Currently these are left unmanaged by default, thus if a user set any
value then remove it later, puppet does not wipe out the parameter
settings added by the previous run.
Change-Id: I9878a6d2258ba32f44773c1b7c3da3dcac71e2a2
In Debian, SPICE is the default. Unfortunately, puppet-openstack fails to
set [spice]/enabled = false when VNC is selected, and therefore, both VNC
and SPICE ends up being enabled in nova.conf.
Also, Debian has a unique package nova-consoleproxy handling SPICE, VNC
and the XenVNC console, with /etc/default/nova-consoleproxy being used to
select what daemon to start. As puppet-openstack doesn't set it before
starting the VNC console service, it stays with spicehtml5 as default
value, and therefore, nova-novncproxy cannot start.
This patch fixes both issues.
Change-Id: Ia40805f27e8833fa01576432ae792e1becedd729
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
order to be prepared for rspec 3.x move.
In details:
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Use shared_examples "a Puppet::Error" for puppet::error tests *
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x) *
* Fix spec tests for rspec-puppet 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
Change-Id: I172439c6ed185bb38b325b2524cab1475cdc7504
