26dbd52717
This change implements the quote parameter in libvirtd_config and virtlogd_config, so that we can quote the value by that simple parameter instead of implementing a logic in each manifests. Also, with this change libvirtd_config and virtlogd_config supports $::os_service_default, so that we can define absence of parameters more easily. Depends-on: https://review.opendev.org/792735 Change-Id: I3030ca34088019be932a9cc33344f7fb473a9aea
72 lines
2.7 KiB
Ruby
72 lines
2.7 KiB
Ruby
# Unit tests for nova::compute::libvirt::virtlogd class
|
|
#
|
|
require 'spec_helper'
|
|
|
|
describe 'nova::compute::libvirt::virtlogd' do
|
|
|
|
let :pre_condition do
|
|
<<-eos
|
|
include nova
|
|
include nova::compute
|
|
include nova::compute::libvirt
|
|
eos
|
|
end
|
|
|
|
shared_examples_for 'nova-compute-libvirt-virtlogd' do
|
|
|
|
context 'with default parameters' do
|
|
let :params do
|
|
{}
|
|
end
|
|
|
|
it { is_expected.to contain_class('nova::deps')}
|
|
it { is_expected.to contain_class('nova::compute::libvirt::virtlogd')}
|
|
|
|
it { is_expected.to contain_virtlogd_config('log_level').with_value('<SERVICE DEFAULT>')}
|
|
it { is_expected.to contain_virtlogd_config('log_outputs').with_value('<SERVICE DEFAULT>').with_quote(true)}
|
|
it { is_expected.to contain_virtlogd_config('log_filters').with_value('<SERVICE DEFAULT>').with_quote(true)}
|
|
it { is_expected.to contain_virtlogd_config('max_clients').with_value('<SERVICE DEFAULT>')}
|
|
it { is_expected.to contain_virtlogd_config('admin_max_clients').with_value('<SERVICE DEFAULT>')}
|
|
it { is_expected.to contain_virtlogd_config('max_size').with_value('<SERVICE DEFAULT>')}
|
|
it { is_expected.to contain_virtlogd_config('max_backups').with_value('<SERVICE DEFAULT>')}
|
|
end
|
|
|
|
context 'with specified parameters' do
|
|
let :params do
|
|
{ :log_level => 3,
|
|
:log_outputs => '3:syslog',
|
|
:log_filters => '1:logging 4:object 4:json 4:event 1:util',
|
|
:max_clients => 1024,
|
|
:admin_max_clients => 5,
|
|
:max_size => 2097152,
|
|
:max_backups => 3,
|
|
}
|
|
end
|
|
|
|
it { is_expected.to contain_class('nova::deps')}
|
|
it { is_expected.to contain_class('nova::compute::libvirt::virtlogd')}
|
|
|
|
it { is_expected.to contain_virtlogd_config('log_level').with_value(params[:log_level])}
|
|
it { is_expected.to contain_virtlogd_config('log_outputs').with_value(params[:log_outputs]).with_quote(true)}
|
|
it { is_expected.to contain_virtlogd_config('log_filters').with_value(params[:log_filters]).with_quote(true)}
|
|
it { is_expected.to contain_virtlogd_config('max_clients').with_value(params[:max_clients])}
|
|
it { is_expected.to contain_virtlogd_config('admin_max_clients').with_value(params[:admin_max_clients])}
|
|
it { is_expected.to contain_virtlogd_config('max_size').with_value(params[:max_size])}
|
|
it { is_expected.to contain_virtlogd_config('max_backups').with_value(params[:max_backups])}
|
|
end
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts())
|
|
end
|
|
|
|
it_configures 'nova-compute-libvirt-virtlogd'
|
|
end
|
|
end
|
|
|
|
end
|