48cd95a59b
After spending huge effort to understand the exact requirements to enforce SRBAC, we learned it's very difficult to find the required scope in each credential. This requires understanding implementation of client-side as well as server-side, and requirement might be different according to the deployment architecture or features used. Instead of implementing support based on the actual implementation, this introduces support for system scope credentials to all places where keystone user credential is defined, and make all credential configurations consistent. Change-Id: I99eb7f368d68e393685041d20cd9adfb8f10eecb
90 lines
4.4 KiB
Ruby
90 lines
4.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'nova::ironic::common' do
|
|
|
|
shared_examples_for 'nova-ironic-common' do
|
|
|
|
context 'with default parameters' do
|
|
it 'configures ironic in nova.conf' do
|
|
is_expected.to contain_nova_config('ironic/auth_plugin').with_value('password')
|
|
is_expected.to contain_nova_config('ironic/username').with_value('admin')
|
|
is_expected.to contain_nova_config('ironic/password').with_value('ironic').with_secret(true)
|
|
is_expected.to contain_nova_config('ironic/auth_url').with_value('http://127.0.0.1:5000/')
|
|
is_expected.to contain_nova_config('ironic/project_name').with_value('services')
|
|
is_expected.to contain_nova_config('ironic/system_scope').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/endpoint_override').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/region_name').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/api_max_retries').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/api_retry_interval').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/user_domain_name').with_value('Default')
|
|
is_expected.to contain_nova_config('ironic/project_domain_name').with_value('Default')
|
|
is_expected.to contain_nova_config('ironic/service_type').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/timeout').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/valid_interfaces').with_value('<SERVICE DEFAULT>')
|
|
end
|
|
end
|
|
|
|
context 'with parameters' do
|
|
let :params do
|
|
{
|
|
:username => 'ironic',
|
|
:password => 's3cr3t',
|
|
:auth_url => 'http://10.0.0.10:5000/',
|
|
:project_name => 'services2',
|
|
:endpoint_override => 'http://10.0.0.10:6385/v1',
|
|
:region_name => 'regionTwo',
|
|
:api_max_retries => 60,
|
|
:api_retry_interval => 2,
|
|
:user_domain_name => 'custom_domain',
|
|
:project_domain_name => 'custom_domain',
|
|
:service_type => 'baremetal',
|
|
:timeout => 30,
|
|
:valid_interfaces => 'internal',
|
|
}
|
|
end
|
|
|
|
it 'configures ironic in nova.conf' do
|
|
is_expected.to contain_nova_config('ironic/auth_plugin').with_value('password')
|
|
is_expected.to contain_nova_config('ironic/username').with_value('ironic')
|
|
is_expected.to contain_nova_config('ironic/password').with_value('s3cr3t').with_secret(true)
|
|
is_expected.to contain_nova_config('ironic/auth_url').with_value('http://10.0.0.10:5000/')
|
|
is_expected.to contain_nova_config('ironic/project_name').with_value('services2')
|
|
is_expected.to contain_nova_config('ironic/system_scope').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/endpoint_override').with_value('http://10.0.0.10:6385/v1')
|
|
is_expected.to contain_nova_config('ironic/region_name').with_value('regionTwo')
|
|
is_expected.to contain_nova_config('ironic/api_max_retries').with_value('60')
|
|
is_expected.to contain_nova_config('ironic/api_retry_interval').with_value('2')
|
|
is_expected.to contain_nova_config('ironic/user_domain_name').with_value('custom_domain')
|
|
is_expected.to contain_nova_config('ironic/project_domain_name').with_value('custom_domain')
|
|
is_expected.to contain_nova_config('ironic/service_type').with_value('baremetal')
|
|
is_expected.to contain_nova_config('ironic/timeout').with_value(30)
|
|
is_expected.to contain_nova_config('ironic/valid_interfaces').with_value('internal')
|
|
end
|
|
end
|
|
|
|
context 'when system_scope is set' do
|
|
let :params do
|
|
{
|
|
:system_scope => 'all'
|
|
}
|
|
end
|
|
it 'configures system-scoped credential' do
|
|
is_expected.to contain_nova_config('ironic/project_domain_name').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/project_name').with_value('<SERVICE DEFAULT>')
|
|
is_expected.to contain_nova_config('ironic/system_scope').with_value('all')
|
|
end
|
|
end
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts)
|
|
end
|
|
it_configures 'nova-ironic-common'
|
|
end
|
|
end
|
|
end
|