Deprecate support for [database] mysql_enable_nbd

Depends-on: https://review.opendev.org/1004735
Change-Id: I7c0254b165131246c9440229ec6af0a61e87fe63
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>

manifests/db.pp

@@ -33,16 +33,18 @@
 #   (Optional) If set, use this value for pool_timeout with SQLAlchemy.
 #   Defaults to $facts['os_service_default']
 #
-# [*mysql_enable_ndb*]
-#   (Optional) If True, transparently enables support for handling MySQL
-#   Cluster (NDB).
-#   Defaults to $facts['os_service_default']
-#
 # [*database_db_max_retries*]
 #   (Optional) Maximum retries in case of connection error or deadlock error
 #   before error is raised. Set to -1 to specify an infinite retry count.
 #   Defaults to $facts['os_service_default']
 #
+# DEPRECATED PARAMETERS
+#
+# [*mysql_enable_ndb*]
+#   (Optional) If True, transparently enables support for handling MySQL
+#   Cluster (NDB).
+#   Defaults to undef
+#
 class octavia::db (
   $database_connection              = 'sqlite:////var/lib/octavia/octavia.sqlite',
   $database_connection_recycle_time = $facts['os_service_default'],
@@ -51,8 +53,9 @@ class octavia::db (
   $database_retry_interval          = $facts['os_service_default'],
   $database_max_overflow            = $facts['os_service_default'],
   $database_pool_timeout            = $facts['os_service_default'],
-  $mysql_enable_ndb                 = $facts['os_service_default'],
   $database_db_max_retries          = $facts['os_service_default'],
+  # DEPRECATED PARAMETERS
+  $mysql_enable_ndb                 = undef,
 ) {
   include octavia::deps
 

releasenotes/notes/deprecate-db-mysql_enable_ndb-7e9cba1fc9f352c5.yaml

@@ -0,0 +1,4 @@
+---
+deprecations:
+  - |
+    The ``octavia::db::mysql_enable_ndb`` parameter has been deprecated.

spec/classes/octavia_db_spec.rb

@@ -12,7 +12,7 @@ describe 'octavia::db' do
         :retry_interval          => '<SERVICE DEFAULT>',
         :max_overflow            => '<SERVICE DEFAULT>',
         :pool_timeout            => '<SERVICE DEFAULT>',
-        :mysql_enable_ndb        => '<SERVICE DEFAULT>',
+        :mysql_enable_ndb        => nil,
       )}
     end