openstack
/
puppet-octavia
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I5eb1051e67a56941b9684728aa4f4340ddb35aab
This commit is contained in:
Takashi Kajinami 2020-08-31 17:53:21 +09:00
parent 0c54350b8e
commit 4491d687b2
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -79,9 +79,6 @@ class octavia::db (
$database_pool_timeout_real = pick($::octavia::database_pool_timeout, $database_pool_timeout)
$database_db_max_retries_real = pick($::octavia::database_db_max_retries, $database_db_max_retries)
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(sqlite|mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'octavia_config':
connection => $database_connection_real,
connection_recycle_time => $database_connection_recycle_time_real,