openstack
/
puppet-octavia
Code Issues Proposed changes

Stop overriding log_file 

Octavia has multiple processes. So if we override log_file, multiple
processes can write into the same file.

Change-Id: I0de1a0d3c76bfac55421832574a90be228d423ee
changes/57/881157/2
Takashi Kajinami 2023-04-21 11:33:21 +09:00
parent 1b10a1bbe7
commit b1586a07e5
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/logging.pp
View File

@ -35,7 +35,7 @@
#
# [*log_file*]
# (Optional) File where logs should be stored.
# Defaults to '/var/log/octavia/octavia.log'
# Defaults to $facts['os_service_default']
#
# [*watch_log_file*]
# (Optional) Uses logging handler designed to watch file system (boolean value).
@ -112,7 +112,7 @@ class octavia::logging(
$use_stderr = $facts['os_service_default'],
$log_facility = $facts['os_service_default'],
$log_dir = '/var/log/octavia',
$log_file = '/var/log/octavia/octavia.log',
$log_file = $facts['os_service_default'],
$watch_log_file = $facts['os_service_default'],
$debug = $facts['os_service_default'],
$logging_context_format_string = $facts['os_service_default'],

6
releasenotes/notes/default-log_file-2324105c32200c85.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Default value of ``octavia::logging::log_file`` has been changed and now
it defaults to service default, to make sure each octavia daemon uses
a specific log file.

2
spec/classes/octavia_logging_spec.rb
View File

@ -66,7 +66,7 @@ describe 'octavia::logging' do
:use_stderr => '<SERVICE DEFAULT>',
:syslog_log_facility => '<SERVICE DEFAULT>',
:log_dir => '/var/log/octavia',
:log_file => '/var/log/octavia/octavia.log',
:log_file => '<SERVICE DEFAULT>',
:watch_log_file => '<SERVICE DEFAULT>',
:debug => '<SERVICE DEFAULT>',
)