openstack/puppet-octavia
Code Issues Proposed changes

Convert to rspec-puppet-facts

Browse Source 
Change-Id: I9c9b18c596faafd408249e4eb0e1e79ac40d699d
This commit is contained in:
Tobias Urdin
2018-11-24 15:55:30 +01:00
parent 0ea4e10dd3
commit e1f114d056
3 changed files with 184 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
spec/classes/octavia_db_mysql_spec.rb
View File

@@ -1,60 +1,71 @@
require 'spec_helper' require 'spec_helper'
describe 'octavia::db::mysql' do describe 'octavia::db::mysql' do
let :pre_condition do let :pre_condition do
[ "include mysql::server
'include mysql::server', include octavia::db::sync"
'include octavia::db::sync'
]
end
let :facts do
{ :osfamily => 'Debian' }
end end
let :params do let :params do
{ {
'password' => 'fooboozoo_default_password', :password => 'fooboozoo_default_password',
} }
end end
describe 'with only required params' do shared_examples 'octavia::db::mysql' do
it { is_expected.to contain_openstacklib__db__mysql('octavia').with( context 'with only required params' do
:user => 'octavia', it { should contain_openstacklib__db__mysql('octavia').with(
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206', :user => 'octavia',
:dbname => 'octavia', :password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
:host => '127.0.0.1', :dbname => 'octavia',
:charset => 'utf8', :host => '127.0.0.1',
:collate => 'utf8_general_ci', :charset => 'utf8',
)} :collate => 'utf8_general_ci',
)}
end
context 'overriding allowed_hosts param to array' do
before do
params.merge!( :allowed_hosts => ['127.0.0.1','%'] )
end
it { should contain_openstacklib__db__mysql('octavia').with(
:user => 'octavia',
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
:dbname => 'octavia',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => ['127.0.0.1','%']
)}
end
context 'overriding allowed_hosts param to string' do
before do
params.merge!( :allowed_hosts => '192.168.1.1' )
end
it { should contain_openstacklib__db__mysql('octavia').with(
:user => 'octavia',
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
:dbname => 'octavia',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => '192.168.1.1'
)}
end
end end
describe "overriding allowed_hosts param to array" do on_supported_os({
before { params.merge!( :allowed_hosts => ['127.0.0.1','%'] ) } :supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
it { is_expected.to contain_openstacklib__db__mysql('octavia').with( it_behaves_like 'octavia::db::mysql'
:user => 'octavia', end
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
:dbname => 'octavia',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => ['127.0.0.1','%']
)}
end end
describe "overriding allowed_hosts param to string" do
before { params.merge!( :allowed_hosts => '192.168.1.1' ) }
it { is_expected.to contain_openstacklib__db__mysql('octavia').with(
:user => 'octavia',
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
:dbname => 'octavia',
:host => '127.0.0.1',
:charset => 'utf8',
:collate => 'utf8_general_ci',
:allowed_hosts => '192.168.1.1'
)}
end
end end

83
spec/classes/octavia_db_spec.rb
View File

@@ -1,10 +1,9 @@
require 'spec_helper' require 'spec_helper'
describe 'octavia::db' do describe 'octavia::db' do
shared_examples 'octavia::db' do shared_examples 'octavia::db' do
context 'with default parameters' do context 'with default parameters' do
it { is_expected.to contain_oslo__db('octavia_config').with( it { should contain_oslo__db('octavia_config').with(
:db_max_retries => '<SERVICE DEFAULT>', :db_max_retries => '<SERVICE DEFAULT>',
:connection => 'sqlite:////var/lib/octavia/octavia.sqlite', :connection => 'sqlite:////var/lib/octavia/octavia.sqlite',
:idle_timeout => '<SERVICE DEFAULT>', :idle_timeout => '<SERVICE DEFAULT>',
@@ -19,7 +18,8 @@ describe 'octavia::db' do
context 'with specific parameters' do context 'with specific parameters' do
let :params do let :params do
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', {
:database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia',
:database_idle_timeout => '3601', :database_idle_timeout => '3601',
:database_min_pool_size => '2', :database_min_pool_size => '2',
:database_max_retries => '11', :database_max_retries => '11',
@@ -31,7 +31,7 @@ describe 'octavia::db' do
} }
end end
it { is_expected.to contain_oslo__db('octavia_config').with( it { should contain_oslo__db('octavia_config').with(
:db_max_retries => '-1', :db_max_retries => '-1',
:connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', :connection => 'mysql+pymysql://octavia:octavia@localhost/octavia',
:idle_timeout => '3601', :idle_timeout => '3601',
@@ -46,83 +46,54 @@ describe 'octavia::db' do
context 'with postgresql backend' do context 'with postgresql backend' do
let :params do let :params do
{ :database_connection => 'postgresql://octavia:octavia@localhost/octavia', } {
end :database_connection => 'postgresql://octavia:octavia@localhost/octavia'
}
it 'install the proper backend package' do
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
end end
it { should contain_package('python-psycopg2').with_ensure('present') }
end end
context 'with MySQL-python library as backend package' do context 'with MySQL-python library as backend package' do
let :params do let :params do
{ :database_connection => 'mysql://octavia:octavia@localhost/octavia', } {
:database_connection => 'mysql://octavia:octavia@localhost/octavia'
}
end end
it { is_expected.to contain_package('python-mysqldb').with(:ensure => 'present') } it { should contain_package('python-mysqldb').with_ensure('present') }
end end
context 'with incorrect database_connection string' do context 'with incorrect database_connection string' do
let :params do let :params do
{ :database_connection => 'foodb://octavia:octavia@localhost/octavia', } {
:database_connection => 'foodb://octavia:octavia@localhost/octavia'
}
end end
it_raises 'a Puppet::Error', /validate_re/ it { should raise_error(Puppet::Error, /validate_re/) }
end end
context 'with incorrect pymysql database_connection string' do context 'with incorrect pymysql database_connection string' do
let :params do let :params do
{ :database_connection => 'foo+pymysql://octavia:octavia@localhost/octavia', } {
:database_connection => 'foo+pymysql://octavia:octavia@localhost/octavia'
}
end end
it_raises 'a Puppet::Error', /validate_re/ it { should raise_error(Puppet::Error, /validate_re/) }
end
end
context 'on Debian platforms' do
let :facts do
@default_facts.merge({
:osfamily => 'Debian',
:operatingsystem => 'Debian',
:operatingsystemrelease => 'jessie',
})
end
it_configures 'octavia::db'
context 'using pymysql driver' do
let :params do
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', }
end
it 'install the proper backend package' do
is_expected.to contain_package('python-pymysql').with(
:ensure => 'present',
:name => 'python-pymysql',
:tag => 'openstack'
)
end
end end
end end
context 'on Redhat platforms' do on_supported_os({
let :facts do :supported_os => OSDefaults.get_supported_os
@default_facts.merge({ }).each do |os,facts|
:osfamily => 'RedHat', context "on #{os}" do
:operatingsystemrelease => '7.1', let (:facts) do
}) facts.merge!(OSDefaults.get_facts())
end
it_configures 'octavia::db'
context 'using pymysql driver' do
let :params do
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', }
end end
it_behaves_like 'octavia::db'
end end
end end
end end

194
spec/classes/octavia_keystone_auth_spec.rb
View File

@@ -1,120 +1,130 @@
#
# Unit tests for octavia::keystone::auth
#
require 'spec_helper' require 'spec_helper'
describe 'octavia::keystone::auth' do describe 'octavia::keystone::auth' do
shared_examples 'octavia::keystone::auth' do
context 'with default class parameters' do
let :params do
{
:password => 'octavia_password',
:tenant => 'foobar'
}
end
let :facts do it { should contain_keystone_user('octavia').with(
{ :osfamily => 'Debian' } :ensure => 'present',
end :password => 'octavia_password',
)}
describe 'with default class parameters' do it { should contain_keystone_user_role('octavia@foobar').with(
let :params do :ensure => 'present',
{ :password => 'octavia_password', :roles => ['admin']
:tenant => 'foobar' } )}
it { should contain_keystone_service('octavia::load-balancer').with(
:ensure => 'present',
:description => 'Octavia Service'
)}
it { should contain_keystone_endpoint('RegionOne/octavia::load-balancer').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:9876',
:admin_url => 'http://127.0.0.1:9876',
:internal_url => 'http://127.0.0.1:9876',
)}
end end
it { is_expected.to contain_keystone_user('octavia').with( context 'when overriding URL parameters' do
:ensure => 'present', let :params do
:password => 'octavia_password', {
) } :password => 'octavia_password',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
}
end
it { is_expected.to contain_keystone_user_role('octavia@foobar').with( it { should contain_keystone_endpoint('RegionOne/octavia::load-balancer').with(
:ensure => 'present', :ensure => 'present',
:roles => ['admin']
)}
it { is_expected.to contain_keystone_service('octavia::load-balancer').with(
:ensure => 'present',
:description => 'Octavia Service'
) }
it { is_expected.to contain_keystone_endpoint('RegionOne/octavia::load-balancer').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:9876',
:admin_url => 'http://127.0.0.1:9876',
:internal_url => 'http://127.0.0.1:9876',
) }
end
describe 'when overriding URL parameters' do
let :params do
{ :password => 'octavia_password',
:public_url => 'https://10.10.10.10:80', :public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81', :internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81', } :admin_url => 'http://10.10.10.12:81',
)}
end end
it { is_expected.to contain_keystone_endpoint('RegionOne/octavia::load-balancer').with( context 'when overriding auth name' do
:ensure => 'present', let :params do
:public_url => 'https://10.10.10.10:80', {
:internal_url => 'http://10.10.10.11:81', :password => 'foo',
:admin_url => 'http://10.10.10.12:81', :auth_name => 'octaviay'
) } }
end end
describe 'when overriding auth name' do it { should contain_keystone_user('octaviay') }
let :params do it { should contain_keystone_user_role('octaviay@services') }
{ :password => 'foo', it { should contain_keystone_service('octavia::load-balancer') }
:auth_name => 'octaviay' } it { should contain_keystone_endpoint('RegionOne/octavia::load-balancer') }
end end
it { is_expected.to contain_keystone_user('octaviay') } context 'when overriding service name' do
it { is_expected.to contain_keystone_user_role('octaviay@services') } let :params do
it { is_expected.to contain_keystone_service('octavia::load-balancer') } {
it { is_expected.to contain_keystone_endpoint('RegionOne/octavia::load-balancer') } :service_name => 'octavia_service',
end :auth_name => 'octavia',
:password => 'octavia_password'
}
end
describe 'when overriding service name' do it { should contain_keystone_user('octavia') }
let :params do it { should contain_keystone_user_role('octavia@services') }
{ :service_name => 'octavia_service', it { should contain_keystone_service('octavia_service::load-balancer') }
:auth_name => 'octavia', it { should contain_keystone_endpoint('RegionOne/octavia_service::load-balancer') }
:password => 'octavia_password' }
end end
it { is_expected.to contain_keystone_user('octavia') } context 'when disabling user configuration' do
it { is_expected.to contain_keystone_user_role('octavia@services') } let :params do
it { is_expected.to contain_keystone_service('octavia_service::load-balancer') } {
it { is_expected.to contain_keystone_endpoint('RegionOne/octavia_service::load-balancer') } :password => 'octavia_password',
end :configure_user => false
}
end
describe 'when disabling user configuration' do it { should_not contain_keystone_user('octavia') }
it { should contain_keystone_user_role('octavia@services') }
let :params do it { should contain_keystone_service('octavia::load-balancer').with(
{ :ensure => 'present',
:password => 'octavia_password', :description => 'Octavia Service'
:configure_user => false )}
}
end end
it { is_expected.not_to contain_keystone_user('octavia') } context 'when disabling user and user role configuration' do
it { is_expected.to contain_keystone_user_role('octavia@services') } let :params do
it { is_expected.to contain_keystone_service('octavia::load-balancer').with( {
:ensure => 'present', :password => 'octavia_password',
:description => 'Octavia Service' :configure_user => false,
) } :configure_user_role => false
}
end
end it { should_not contain_keystone_user('octavia') }
it { should_not contain_keystone_user_role('octavia@services') }
describe 'when disabling user and user role configuration' do it { should contain_keystone_service('octavia::load-balancer').with(
:ensure => 'present',
let :params do :description => 'Octavia Service'
{ )}
:password => 'octavia_password',
:configure_user => false,
:configure_user_role => false
}
end end
it { is_expected.not_to contain_keystone_user('octavia') }
it { is_expected.not_to contain_keystone_user_role('octavia@services') }
it { is_expected.to contain_keystone_service('octavia::load-balancer').with(
:ensure => 'present',
:description => 'Octavia Service'
) }
end end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
it_behaves_like 'octavia::keystone::auth'
end
end
end end