openstack
/
puppet-octavia
Code Issues Proposed changes

Add octavia::glance to configure glance section 

Adds new class octavia::glance that can be used to
configure the glance section in octavia.conf

Change-Id: I249269aa774955bbb1d41e5808ac8d09fbe8598f
(cherry picked from commit 6731e53bb5)
This commit is contained in:
Tobias Urdin 2018-08-30 11:40:02 +02:00
parent 156c159fa6
commit f5caf142f4
3 changed files with 88 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
manifests/glance.pp Normal file
View File

@ -0,0 +1,38 @@
# == Class: octavia::glance
#
# Setup and configure octavia.conf glance section.
#
# === Parameters:
#
# [*service_name*]
# (Optional) The name of the glance service in the keystone catalog.
# Defaults to $::os_service_default
#
# [*endpoint*]
# (Optional) Custom glance endpoint if override is necessary.
# Defaults to $::os_service_default
#
# [*region_name*]
# (Optional) Region in catalog to use for glance.
# Defaults to $::os_service_default
#
# [*endpoint_type*]
# (Optional) Endpoint type in catalog to use for glance.
# Defaults to $::os_service_default
#
class octavia::glance (
$service_name = $::os_service_default,
$endpoint = $::os_service_default,
$region_name = $::os_service_default,
$endpoint_type = $::os_service_default,
) {
include ::octavia::deps
octavia_config {
'glance/service_name': value => $service_name;
'glance/endpoint': value => $endpoint;
'glance/region_name': value => $region_name;
'glance/endpoint_type': value => $endpoint_type;
}
}

5
releasenotes/notes/octavia-glance-37d48b9829d6ca8d.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Added new octavia::glance class that can be used to configure the glance section
in octavia.conf

45
spec/classes/octavia_glance_spec.rb Normal file
View File

@ -0,0 +1,45 @@
require 'spec_helper'
describe 'octavia::glance' do
shared_examples 'octavia::glance' do
context 'with default parameters' do
it {
should contain_octavia_config('glance/service_name').with_value('<SERVICE DEFAULT>')
should contain_octavia_config('glance/endpoint').with_value('<SERVICE DEFAULT>')
should contain_octavia_config('glance/region_name').with_value('<SERVICE DEFAULT>')
should contain_octavia_config('glance/endpoint_type').with_value('<SERVICE DEFAULT>')
}
end
context 'with specified parameters' do
let :params do
{
:service_name => 'image',
:endpoint => 'http://127.0.0.1:9292',
:region_name => 'RegionOne',
:endpoint_type => 'internalURL',
}
end
it {
should contain_octavia_config('glance/service_name').with_value('image')
should contain_octavia_config('glance/endpoint').with_value('http://127.0.0.1:9292')
should contain_octavia_config('glance/region_name').with_value('RegionOne')
should contain_octavia_config('glance/endpoint_type').with_value('internalURL')
}
end
end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge(OSDefaults.get_facts())
end
it_behaves_like 'octavia::glance'
end
end
end