8062f88888
1) The host and port options[1] should be bind_host and bind_port. The host option[2] is the hostname that Octavia is running on. See log[3]. So fix it. [1]https://github.com/openstack/octavia/blob/master/octavia/common/config.py#L33 [2]https://github.com/openstack/octavia/blob/master/octavia/common/config.py#L53 [3]http://logs.openstack.org/55/467855/1/check/gate-puppet-octavia-puppet-beaker-rspec-centos-7/9c5655b/logs/octavia/worker.txt.gz#_2017-06-09_00_54_01_238 2) Fix unit test The db_backend_package name has changed in puppet-oslo[0], so fix it. [0]: https://review.openstack.org/#/c/467582/ Change-Id: I1b27e61247130df57d9c34e80cfdc96d35e2bdc4 Closes-Bug: #1693403 Closes-Bug: #1696890
126 lines
3.5 KiB
Ruby
126 lines
3.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'octavia::db' do
|
|
|
|
shared_examples 'octavia::db' do
|
|
context 'with default parameters' do
|
|
it { is_expected.to contain_oslo__db('octavia_config').with(
|
|
:db_max_retries => '<SERVICE DEFAULT>',
|
|
:connection => 'sqlite:////var/lib/octavia/octavia.sqlite',
|
|
:idle_timeout => '<SERVICE DEFAULT>',
|
|
:min_pool_size => '<SERVICE DEFAULT>',
|
|
:max_pool_size => '<SERVICE DEFAULT>',
|
|
:max_retries => '<SERVICE DEFAULT>',
|
|
:retry_interval => '<SERVICE DEFAULT>',
|
|
:max_overflow => '<SERVICE DEFAULT>',
|
|
)}
|
|
end
|
|
|
|
context 'with specific parameters' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia',
|
|
:database_idle_timeout => '3601',
|
|
:database_min_pool_size => '2',
|
|
:database_max_retries => '11',
|
|
:database_retry_interval => '11',
|
|
:database_max_pool_size => '11',
|
|
:database_max_overflow => '21',
|
|
:database_db_max_retries => '-1',
|
|
}
|
|
end
|
|
|
|
it { is_expected.to contain_oslo__db('octavia_config').with(
|
|
:db_max_retries => '-1',
|
|
:connection => 'mysql+pymysql://octavia:octavia@localhost/octavia',
|
|
:idle_timeout => '3601',
|
|
:min_pool_size => '2',
|
|
:max_pool_size => '11',
|
|
:max_retries => '11',
|
|
:retry_interval => '11',
|
|
:max_overflow => '21',
|
|
)}
|
|
end
|
|
|
|
context 'with postgresql backend' do
|
|
let :params do
|
|
{ :database_connection => 'postgresql://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
it 'install the proper backend package' do
|
|
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
|
|
end
|
|
|
|
end
|
|
|
|
context 'with MySQL-python library as backend package' do
|
|
let :params do
|
|
{ :database_connection => 'mysql://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
it { is_expected.to contain_package('python-mysqldb').with(:ensure => 'present') }
|
|
end
|
|
|
|
context 'with incorrect database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'foodb://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
context 'with incorrect pymysql database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'foo+pymysql://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
end
|
|
|
|
context 'on Debian platforms' do
|
|
let :facts do
|
|
@default_facts.merge({
|
|
:osfamily => 'Debian',
|
|
:operatingsystem => 'Debian',
|
|
:operatingsystemrelease => 'jessie',
|
|
})
|
|
end
|
|
|
|
it_configures 'octavia::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
it 'install the proper backend package' do
|
|
is_expected.to contain_package('python-pymysql').with(
|
|
:ensure => 'present',
|
|
:name => 'python-pymysql',
|
|
:tag => 'openstack'
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'on Redhat platforms' do
|
|
let :facts do
|
|
@default_facts.merge({
|
|
:osfamily => 'RedHat',
|
|
:operatingsystemrelease => '7.1',
|
|
})
|
|
end
|
|
|
|
it_configures 'octavia::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://octavia:octavia@localhost/octavia', }
|
|
end
|
|
|
|
end
|
|
end
|
|
|
|
end
|