openstack
/
puppet-openstack-guide
Code Issues Proposed changes

Merge "Add explanation about dependency management"

This commit is contained in:
Zuul 2021-06-08 18:25:57 +00:00 committed by Gerrit Code Review
parent feeb9b6f3f bb57f1e6f9
commit cebdcda716
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/source/contributor/coding-style.rst
View File

@ -92,6 +92,17 @@ When you need to specify an empty (nil) parameter, using
is the best choice. Do not useː " (not Puppetish) or false (undef is
false if tested as a boolean).
Adding new depdnency
~~~~~~~~~~~~~~~~~~~~
When you add a new dependency, update ``metadata.json`` in that repository.
If the new dependency is not yet used by the other modules, then that should be added to
`Puppetfile <https://opendev.org/openstack/puppet-openstack-integration/src/branch/master/Puppetfile>`__
so that the new dependency is installed during tests.
If the new depdnency is already used in the other modules, then set the consistent
version constraints unless you have a specific requirement,
Testing
=======