openstack
/
puppet-openstack-integration
Code Issues Proposed changes

Disable strict variables for unit tests 

So rspec-puppet 2.4+ has strict variables enabled
which causes test failures. The problem is that the puppet modules
have never worked with strict_variables = true due to backwards
compatibility & import ordering.  Since this has not been true,
lets disable it in the unit testing for now. Perhaps some day
we will be able to turn this back to true.  This should allow us to lift
the 2.3.x cap that we added as part of
https://review.opendev.org/#/c/618854/.

Change-Id: Idbf837e87072c829c94e0356b8536088cf98c3bb
This commit is contained in:
Alex Schultz 2019-04-23 17:26:11 -06:00
parent 12d1bd446b
commit 0914577244
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
playbooks/run-libraries-unit-tests.yaml
View File

@ -9,6 +9,13 @@
fi
# TODO(tobias-urdin): Remove when we dont pin rspec-puppet
export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}'
# NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled
# which causes test failures. The problem is that the puppet modules
# have never worked with strict_variables = true due to backwards
# compatibility & import ordering. Since this has not been true,
# lets disable it in the unit testing for now. Perhaps some day
# we will be able to turn this back to true.
export STRICT_VARIABLES=no
./run_unit_tests.sh
executable: /bin/bash
chdir: '{{ ansible_user_dir }}/workspace'

7
playbooks/run-unit-tests.yaml
View File

@ -8,6 +8,13 @@
fi
# TODO(tobias-urdin): Remove when we dont pin rspec-puppet
export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}'
# NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled
# which causes test failures. The problem is that the puppet modules
# have never worked with strict_variables = true due to backwards
# compatibility & import ordering. Since this has not been true,
# lets disable it in the unit testing for now. Perhaps some day
# we will be able to turn this back to true.
export STRICT_VARIABLES=no
mkdir .bundled_gems
export GEM_HOME=`pwd`/.bundled_gems
ruby <<EOF