openstack/puppet-openstack-integration
Code Issues Proposed changes

Do not disable strict_variables check

Browse Source 
Starting from 8, puppet requires that all variables are defined in
advance. Enable the check to detect any potential problems.

Change-Id: Iffca5cbf2719e98d7f188f97871fb29caac37a8e
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-08-18 22:14:40 +09:00
parent b80f5c1bff
commit 123ba9ece8
2 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
playbooks/run-libraries-unit-tests.yaml
View File

@@ -10,13 +10,6 @@
if [ "{{ rspec_puppet_version }}" != "latest" ]; then if [ "{{ rspec_puppet_version }}" != "latest" ]; then
export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}' export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}'
fi fi
# NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled
# which causes test failures. The problem is that the puppet modules
# have never worked with strict_variables = true due to backwards
# compatibility & import ordering. Since this has not been true,
# lets disable it in the unit testing for now. Perhaps some day
# we will be able to turn this back to true.
export STRICT_VARIABLES=no
./run_unit_tests.sh ./run_unit_tests.sh
executable: /bin/bash executable: /bin/bash
chdir: '{{ ansible_user_dir }}/workspace' chdir: '{{ ansible_user_dir }}/workspace'

7
playbooks/run-unit-tests.yaml
View File

@@ -9,13 +9,6 @@
if [ "{{ rspec_puppet_version }}" != "latest" ]; then if [ "{{ rspec_puppet_version }}" != "latest" ]; then
export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}' export RSPEC_PUPPET_VERSION='{{ rspec_puppet_version }}'
fi fi
# NOTE(aschultz): rspec-puppet 2.4+ has strict variables enabled
# which causes test failures. The problem is that the puppet modules
# have never worked with strict_variables = true due to backwards
# compatibility & import ordering. Since this has not been true,
# lets disable it in the unit testing for now. Perhaps some day
# we will be able to turn this back to true.
export STRICT_VARIABLES=no
mkdir .bundled_gems mkdir .bundled_gems
export GEM_HOME=`pwd`/.bundled_gems export GEM_HOME=`pwd`/.bundled_gems
export GEM_BIN_DIR=$GEM_HOME/bin export GEM_BIN_DIR=$GEM_HOME/bin