Switch to using build-openstack-puppet-tarball

Replace the legacy puppet-openstack-module-build with native zuulv3
job.

Change-Id: I80bd829320b0c75b550c21a17fcc1a2b8e99ed2a
Co-Authored-By: Paul Belanger <pabelanger@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

.zuul.yaml

@@ -344,14 +344,6 @@
     vars:
       puppet: 4
 
-- job:
-    name: puppet-openstack-module-build
-    parent: puppet-openstack-module-base
-    run: playbooks/run-build-tests.yaml
-    files: ^metadata.json$
-    vars:
-      use_puppetlabs: true
-
 - job:
     name: puppet-openstack-unit-base
     parent: puppet-openstack-integration-base
@@ -417,16 +409,18 @@
     name: puppet-openstack-check-jobs
     check:
       jobs:
+        - build-openstack-puppet-tarball:
+            files: ^metadata.json$
         - puppet-openstack-lint
         - puppet-openstack-syntax-3-legacy
         - puppet-openstack-syntax-4
-        - puppet-openstack-module-build
     gate:
       jobs:
+        - build-openstack-puppet-tarball:
+            files: ^metadata.json$
         - puppet-openstack-lint
         - puppet-openstack-syntax-3-legacy
         - puppet-openstack-syntax-4
-        - puppet-openstack-module-build
 
 - project:
     name: openstack/puppet-openstack-integration

playbooks/run-build-tests.yaml

@@ -1,5 +0,0 @@
-- hosts: all
-  tasks:
-    - shell: /opt/puppetlabs/bin/puppet module build .
-      args:
-        chdir: '{{ zuul.project.src_dir }}'