From 82bc379060acfa212e371c0602389077ee60e398 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Sun, 26 Feb 2023 01:56:47 +0900 Subject: [PATCH] Remove unused logic with outdated comments We currently disable catch_selinux_alerts because of frequent timeout caused by selinux alerts, but having these old logics/comments can be confusing for future maintenance. Change-Id: Idd433c333a38a968622a97e0628e9eb8feb6fa24 --- functions | 8 -------- 1 file changed, 8 deletions(-) diff --git a/functions b/functions index 584c346d7..c07544794 100644 --- a/functions +++ b/functions @@ -255,14 +255,6 @@ function catch_selinux_alerts() { # https://bugzilla.redhat.com/show_bug.cgi?id=1341738 if $SUDO grep -iqE 'denied.*system_r:rabbitmq_t' /var/log/audit/audit.log; then echo "non-critical RabbitMQ AVC, ignoring it now." - # FIXME(ykarel) catch_selinux_alerts not work with non ssl scenarios(no rabbitmq alert), - # currently running all scenarios without ssl in Fedora and CentOS8, - # because glance,nova,mistral py3 has issues when running with eventlet + ssl: - # glance https://bugs.launchpad.net/glance/+bug/1769006 - # nova https://bugs.launchpad.net/nova/+bug/1808975 - # mistral https://bugs.launchpad.net/mistral/+bug/1808953 - elif [ -f /etc/fedora-release ] || [[ "${ID,,}" = "centos" ]]; then - echo "non ssl scenario, ignoring it now." else echo "Please file a bug on https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20OpenStack&component=openstack-selinux showing sealert output." exit 1