Fix RST tests

Now that I79da2cb55ae6b1849001fe05f96c4ed35351c356 is merged we need to
actually follow the template and use correct RST syntax. This patch
corrects some of our errors and modifies the tests to align with our
template.

Change-Id: Ic86a30fc7ce63a287578ee01c7fa11ce5f785577

specs/icehouse/common-openstack-configuration-provider.rst

@@ -47,12 +47,25 @@ We could also try proposing our features and changes to upstream so
 we don't have to maintain them anymore. Those changes might however not
 fit the vision of upstream, like the capitalization of boolean values.
 
+Data model impact
+-----------------
+
+None
 
 Module API impact
 -----------------
 
 This proposition does not include any change to any module API.
 
+End user impact
+---------------
+
+None
+
+Performance Impact
+------------------
+
+None
 
 Deployer impact
 ---------------
@@ -62,6 +75,10 @@ This proposition introduces a new mandatory dependency on openstacklib.
 Those deploying from the master branch and/or using Puppetfile would need to
 install the openstacklib puppet module.
 
+Developer impact
+----------------
+
+None
 
 Implementation
 ==============
@@ -95,6 +112,10 @@ Testing
 * Unit test fixtures of all puppet modules would need to be updated
   to install openstacklib.
 
+Documentation Impact
+====================
+
+None
 
 References
 ==========

specs/icehouse/common-openstack-database-resource.rst

@@ -86,7 +86,7 @@ Module API impact
 
 * Example use case for openstacklib::db::mysql:
 
-  In ::nova::db::mysql:
+  In ::nova::db::mysql::
 
     ::openstacklib::db::mysql { 'nova':
       password_hash => '2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19',
@@ -97,7 +97,7 @@ Module API impact
   would not allow other hosts access to the database. It will re-execute the
   'nova-db-sync' exec when the database refreshes.
 
-  Another example in ::keystone::db::mysql:
+  Another example in ::keystone::db::mysql::
 
     ::openstacklib::db::mysql { 'keystone':
       password_hash  => '2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19',
@@ -125,7 +125,7 @@ Module API impact
 
 * Example use case for openstacklib::db::postgresql
 
-  In ::nova::db::postgresql:
+  In ::nova::db::postgresql::
 
     ::openstacklib::db::postgresql { 'nova':
       password_hash => '2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19',
@@ -135,7 +135,7 @@ Module API impact
   would create a postgresql database called 'nova' with user 'nova'. It will
   re-execute the 'nova-db-sync' exec when the database refreshes.
 
-  Another example in ::keystone::db::postgresql:
+  Another example in ::keystone::db::postgresql::
 
     ::openstacklib::db::postgresql { 'keystone':
       password_hash => '2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19',

specs/icehouse/common-openstack-identity-resource.rst

@@ -86,7 +86,7 @@ Module API impact
 
 * Example use case for openstacklib::service_identity:
 
-  In ::nova::keystone::auth:
+  In ::nova::keystone::auth::
 
     ::openstacklib::service_identity { 'nova':
       password         => 'secrete',

specs/icehouse/use-aviator-in-module-resources.rst

@@ -105,10 +105,11 @@ method and an endpoint method, both of which will accept parameters that can
 be passed from a type's parameters as well as the service being utilized. The
 providers in the openstack modules will use this class as a :parent, e.g.::
 
-Puppet::Type.type(:keystone_service).provide(
-  :aviator,
-  :parent => Puppet::Provider::Aviator
-) do
+    Puppet::Type.type(:keystone_service).provide(
+      :aviator,
+      :parent => Puppet::Provider::Aviator
+    ) do
+
 
 The authenticate method will replace methods like auth_keystone and
 auth_neutron. The endpoint method will replace methods like get_admin_endpoint

tests/test_titles.py

@@ -38,7 +38,7 @@ class TestTitles(testtools.TestCase):
         return titles
 
     def _check_titles(self, titles):
-        self.assertEqual(8, len(titles))
+        self.assertEqual(7, len(titles))
 
         problem = 'Problem description'
         self.assertIn(problem, titles)
@@ -50,12 +50,10 @@ class TestTitles(testtools.TestCase):
             [
                 'Alternatives',
                 'Data model impact',
-                'REST API impact',
-                'Security impact',
-                'Pipeline impact',
-                'Other end user impact',
-                'Performance/Scalability Impacts',
-                'Other deployer impact',
+                'Module API impact',
+                'End user impact',
+                'Performance Impact',
+                'Deployer impact',
                 'Developer impact',
             ],
             titles[proposed])