openstack
/
puppet-openstack_extras
Code Issues Proposed changes

Set show_diff to false for auth_file 

We should not show changes in output since
the password might be leaked there.

I will add a follow-up patch later in master
that cleans up testing and etc.

We need to backport this to all versions.

Change-Id: Ief909c8303d7d29dcd0c19ee4cb4974667eadbcb
(cherry picked from commit 1c072a304e)
This commit is contained in:
Tobias Urdin 2020-02-13 23:52:19 +01:00
parent d650bd8208
commit 5efaf8ac38
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
manifests/auth_file.pp
View File

@ -152,10 +152,11 @@ class openstack_extras::auth_file(
fail('You must specify a password for openstack_extras::auth_file') fail('You must specify a password for openstack_extras::auth_file')
} }
file { $path: file { $path:
owner => 'root', owner => 'root',
group => 'root', group => 'root',
mode => '0700', mode => '0700',
tag => ['openrc'], show_diff => false,
content => template('openstack_extras/openrc.erb') tag => ['openrc'],
content => template('openstack_extras/openrc.erb')
} }
} }