Fix metadata.json lint issues

- Update license name to match a valid SPDX ID.
https://docs.puppetlabs.com/puppet/latest/reference/modules_publishing.html

Change-Id: Ia6697eba8318a81dcf489ffd02316cb1b0ec6f0f
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>

Gemfile

@@ -4,6 +4,7 @@ group :development, :test do
   gem 'puppetlabs_spec_helper', :require => false
 
   gem 'puppet-lint', '~> 1.1.0'
+  gem 'metadata-json-lint'
   gem 'puppet-lint-absolute_classname-check'
   gem 'puppet-lint-absolute_template_path'
   gem 'puppet-lint-trailing_newline-check'

metadata.json

@@ -3,7 +3,7 @@
   "version": "5.0.0",
   "author": "Puppet Labs and StackForge Contributors",
   "summary": "Puppet OpenStack Libraries",
-  "license": "Apache License 2.0",
+  "license": "Apache-2.0",
   "source": "git://github.com/stackforge/puppet-openstacklib.git",
   "project_page": "https://launchpad.net/puppet-openstacklib",
   "issues_url": "https://bugs.launchpad.net/puppet-openstacklib",