Add strict validation about boolean parameters

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: Ie9214b3324166a795b2d3aaf098852c8706bc8a0

manifests/db/mysql.pp

@@ -80,6 +80,9 @@ define openstacklib::db::mysql (
   include mysql::server
   include mysql::client
 
+  validate_legacy(Boolean, 'validate_bool', $create_user)
+  validate_legacy(Boolean, 'validate_bool', $create_grant)
+
   if $password_hash != undef {
     warning('The password_hash parameter was deprecated and will be removed
 in a future release. Use password instead')

manifests/db/mysql/host_access.pp

@@ -48,6 +48,8 @@ define openstacklib::db::mysql::host_access (
 
   validate_legacy(Pattern[/_/], 'validate_re', $title,
     ['_', 'Title must be $dbname_$host'])
+  validate_legacy(Boolean, 'validate_bool', $create_user)
+  validate_legacy(Boolean, 'validate_bool', $create_grant)
 
   $host = inline_template('<%= @title.split("_").last.downcase %>')
 

manifests/iscsid.pp

@@ -23,6 +23,8 @@ class openstacklib::iscsid(
 ) {
 
   include openstacklib::params
+  validate_legacy(Boolean, 'validate_bool', $enabled)
+  validate_legacy(Boolean, 'validate_bool', $manage_service)
 
   package { 'open-iscsi':
     ensure => $package_ensure,

manifests/messaging/rabbitmq.pp

@@ -73,6 +73,10 @@ define openstacklib::messaging::rabbitmq(
   $manage_user_permissions = true,
   $manage_vhost            = true,
 ) {
+  validate_legacy(Boolean, 'validate_bool', $is_admin)
+  validate_legacy(Boolean, 'validate_bool', $manage_user)
+  validate_legacy(Boolean, 'validate_bool', $manage_user_permissions)
+  validate_legacy(Boolean, 'validate_bool', $manage_vhost)
 
   if $manage_user {
     if $userid == 'guest' {

manifests/policy.pp

@@ -44,6 +44,7 @@ define openstacklib::policy (
 ) {
   validate_legacy(Hash, 'validate_hash', $policies)
   validate_legacy(Stdlib::Absolutepath, 'validate_absolute_path', $policy_path)
+  validate_legacy(Boolean, 'validate_bool', $purge_config)
 
   if empty($policies) {
     create_resources('openstacklib::policy::default', { $policy_path => {

manifests/policy/base.pp

@@ -47,6 +47,8 @@ define openstacklib::policy::base (
   $purge_config = false,
 ) {
 
+  validate_legacy(Boolean, 'validate_bool', $purge_config)
+
   ensure_resource('openstacklib::policy::default', $file_path, {
     file_path    => $file_path,
     file_mode    => $file_mode,

manifests/policy/default.pp

@@ -38,6 +38,7 @@ define openstacklib::policy::default (
   $file_format  = 'json',
   $purge_config = false,
 ) {
+  validate_legacy(Boolean, 'validate_bool', $purge_config)
 
   case $file_format {
     'json': {