openstack
/
puppet-openstacklib
Code Issues Proposed changes

Stop testing underlying default in puppetlabs-apache 

When passing undef(nil) to a defined resource type then the value is
just ignored and the default value in the defined resource type is
used. Because of this any change in default value in the dependent
module can directly break our unit tests if we strictly assert behavior
with undef passed.

This change removes a few validations which effectively assert defaults
in puppetlabs-apache. They updated a few default values in 8.0.0 and
that is causing multiple failures now.

Related-Bug: #1983300
Change-Id: I7bbe54972143bd51e41f73ccc838fd222788b08d
This commit is contained in:
Takashi Kajinami 2022-08-10 11:39:21 +09:00
parent a11ca496f7
commit ba19e6dbd3
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spec/defines/openstacklib_wsgi_apache_spec.rb
View File

@ -74,7 +74,7 @@ describe 'openstacklib::wsgi::apache' do
:docroot_owner => 'keystone',
:docroot_group => 'keystone',
:setenv => [],
:ssl => 'true',
:ssl => true,
:ssl_verify_client => 'optional',
:wsgi_daemon_process => {
'keystone_wsgi' => {
@ -87,21 +87,7 @@ describe 'openstacklib::wsgi::apache' do
:wsgi_process_group => 'keystone_wsgi',
:wsgi_script_aliases => { '/' => "/var/www/cgi-bin/keystone/main" },
:wsgi_application_group => '%{GLOBAL}',
:headers => nil,
:request_headers => nil,
:aliases => nil,
:setenvif => ['X-Forwarded-Proto https HTTPS=1'],
# TODO(tkajinam): Replace false by undef once the new puppetlabs-apache
# is released.
# https://github.com/puppetlabs/puppetlabs-apache/commit/f41251e3
:access_log_file => false,
:access_log_pipe => false,
:access_log_syslog => false,
:access_log_format => false,
:error_log_file => nil,
:error_log_pipe => nil,
:error_log_syslog => nil,
:log_level => nil,
:options => ['-Indexes', '+FollowSymLinks','+MultiViews'],
)}