e4b68e9ad6
Currently openstacklib only accepts password_hash instead of password
for db credentials, thus we should implement hashing process in each
modules, with including puppet-mysql and puppet-postgresql.
This patch migrates that hash generation to puppet-openstacklib, so
that all logics related to db is gathered in one module.
In addition, because postgresql_password function was deprecated in
favor of postgresql::postgresql_password in puppet-postgresql
6.5.0[1], this patch also deals with that deprecation.
[1] 700d2c5bb5
Change-Id: I898d31e88188bfd3476412a37f48fc918122a98a
284 lines
7.9 KiB
Ruby
284 lines
7.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'openstacklib::db::mysql' do
|
|
let :pre_condition do
|
|
'include mysql::server'
|
|
end
|
|
|
|
let (:title) { 'nova' }
|
|
|
|
let :required_params do
|
|
{
|
|
:password => 'fooboozoo_default_password',
|
|
}
|
|
end
|
|
|
|
shared_examples 'openstacklib::db::mysql examples' do
|
|
context 'with only required parameters' do
|
|
let :params do
|
|
required_params
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:database => title,
|
|
:privileges => 'ALL',
|
|
:tls_options => ['NONE'],
|
|
)}
|
|
end
|
|
|
|
context 'with overriding dbname parameter' do
|
|
let :params do
|
|
required_params.merge!( :dbname => 'foobar' )
|
|
end
|
|
|
|
it { should contain_mysql_database(params[:dbname]).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{params[:dbname]}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:database => params[:dbname],
|
|
:privileges => 'ALL',
|
|
:create_user => true,
|
|
:create_grant => true,
|
|
:tls_options => ['NONE'],
|
|
)}
|
|
end
|
|
|
|
context 'with overriding user parameter' do
|
|
let :params do
|
|
required_params.merge!( :user => 'foobar' )
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => params[:user],
|
|
:plugin => nil,
|
|
:database => title,
|
|
:privileges => 'ALL',
|
|
:create_user => true,
|
|
:create_grant => true,
|
|
:tls_options => ['NONE'],
|
|
)}
|
|
end
|
|
|
|
context 'with overriding authentication plugin' do
|
|
let :params do
|
|
required_params.merge!(
|
|
:plugin => 'mysql_native_password',
|
|
)
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => params[:plugin],
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title,
|
|
:privileges => 'ALL',
|
|
:create_user => true,
|
|
:create_grant => true,
|
|
:tls_options => ['NONE'],
|
|
)}
|
|
end
|
|
|
|
context 'when overriding charset parameter' do
|
|
let :params do
|
|
required_params.merge!( :charset => 'latin1' )
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with_charset(params[:charset]) }
|
|
end
|
|
|
|
context 'when omitting the required parameter password' do
|
|
let :params do
|
|
{}
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error) }
|
|
end
|
|
|
|
context 'when deprecated password_hash is used' do
|
|
let :params do
|
|
{ :password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206' }
|
|
end
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
)}
|
|
end
|
|
|
|
context 'when notifying other resources' do
|
|
let :pre_condition do
|
|
'exec {"nova-db-sync":}'
|
|
end
|
|
|
|
let :params do
|
|
required_params.merge!( :notify => 'Exec[nova-db-sync]' )
|
|
end
|
|
|
|
it { should contain_exec('nova-db-sync').that_subscribes_to("Openstacklib::Db::Mysql[#{title}]") }
|
|
end
|
|
|
|
context 'when required for other openstack services' do
|
|
let :pre_condition do
|
|
'service {"keystone":}'
|
|
end
|
|
|
|
let :title do
|
|
'keystone'
|
|
end
|
|
|
|
let :params do
|
|
required_params.merge!( :before => 'Service[keystone]' )
|
|
end
|
|
|
|
it { should contain_service('keystone').that_requires("Openstacklib::Db::Mysql[keystone]") }
|
|
end
|
|
|
|
context "overriding allowed_hosts parameter with array value" do
|
|
let :params do
|
|
required_params.merge!( :allowed_hosts => ['127.0.0.1', '%'] )
|
|
end
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_%").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title
|
|
)}
|
|
end
|
|
|
|
context "overriding allowed_hosts parameter with string value" do
|
|
let :params do
|
|
required_params.merge!( :allowed_hosts => '192.168.1.1' )
|
|
end
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_192.168.1.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title
|
|
)}
|
|
end
|
|
|
|
context "overriding allowed_hosts parameter equals to host param " do
|
|
let :params do
|
|
required_params.merge!( :allowed_hosts => '127.0.0.1' )
|
|
end
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title
|
|
)}
|
|
end
|
|
|
|
context 'with skipping user creation' do
|
|
let :params do
|
|
required_params.merge!( :create_user => false )
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:database => title,
|
|
:privileges => 'ALL',
|
|
:create_user => false,
|
|
:create_grant => true,
|
|
)}
|
|
end
|
|
|
|
context 'with skipping grant creation' do
|
|
let :params do
|
|
required_params.merge!( :create_grant => false )
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:database => title,
|
|
:privileges => 'ALL',
|
|
:create_user => true,
|
|
:create_grant => false,
|
|
)}
|
|
end
|
|
|
|
context 'with skipping user and grant creation' do
|
|
let :params do
|
|
required_params.merge!( :create_user => false,
|
|
:create_grant => false )
|
|
end
|
|
|
|
it { should contain_mysql_database(title).with(
|
|
:charset => 'utf8',
|
|
:collate => 'utf8_general_ci'
|
|
)}
|
|
|
|
it { should_not contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1") }
|
|
end
|
|
|
|
context 'overriding tls_options' do
|
|
let :params do
|
|
required_params.merge!( :tls_options => ['SSL'] )
|
|
end
|
|
|
|
it { should contain_openstacklib__db__mysql__host_access("#{title}_127.0.0.1").with(
|
|
:user => title,
|
|
:plugin => nil,
|
|
:password_hash => '*3DDF34A86854A312A8E2C65B506E21C91800D206',
|
|
:database => title,
|
|
:tls_options => ['SSL'],
|
|
)}
|
|
end
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts())
|
|
end
|
|
|
|
it_behaves_like 'openstacklib::db::mysql examples'
|
|
end
|
|
end
|
|
end
|