puppet-openstacklib/releasenotes/notes/os-withenv-3ca466fde75f6441.yaml at 98e64c6dad3b6657458f3d8510e13841305bcfd0 - puppet-openstacklib - OpenDev: Free Software Needs Free Tools

openstack/puppet-openstacklib

Files

Tobias Urdin 98e64c6dad Replace Puppet::Util::withenv with custom version

... that filters out OS_* environment variables
from the existing copied ENV and then set the
passed environment variables to ENV and yield
to the openstack CLI call.

This has been a problem for a very long this
where if you source OS_* environment in your
shell and try to run Puppet the openstack CLI
calls executed by the Puppet modules will
pick up these environment variables causing
side effects such as `openstack token issue`
commands failing to test password for keystone_user
resources causing a `openstack uset set` command
even though the password has not changed.

Conflicts:
	spec/unit/provider/openstack_spec.rb

Change-Id: Ic4f9d7f7e8faf5ba5caaade49f10789aa8dba864
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit 864f02dda6)
(cherry picked from commit 2e85937d75)
(cherry picked from commit 12557ed183)

2025-11-25 19:12:08 +09:00

7 lines

220 B

YAML

Raw Blame History

 ---
 fixes:
   - |
     The ``Puppet::Provider::Openstack.request`` now filters out all external
     ``OS_*`` environment variables to prevent collisions with environment
     variables in the shell where Puppet is running.