
Currently openstacklib only accepts password_hash instead of password
for db credentials, thus we should implement hashing process in each
modules, with including puppet-mysql and puppet-postgresql.
This patch migrates that hash generation to puppet-openstacklib, so
that all logics related to db is gathered in one module.
In addition, because postgresql_password function was deprecated in
favor of postgresql::postgresql_password in puppet-postgresql
6.5.0[1], this patch also deals with that deprecation.
[1] 700d2c5bb5
Change-Id: I898d31e88188bfd3476412a37f48fc918122a98a
98 lines
2.3 KiB
Ruby
98 lines
2.3 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'openstacklib::db::postgresql' do
|
|
let (:title) { 'nova' }
|
|
|
|
let :required_params do
|
|
{
|
|
:password => 'pw'
|
|
}
|
|
end
|
|
|
|
let (:pre_condition) do
|
|
"include postgresql::server"
|
|
end
|
|
|
|
shared_examples 'openstacklib::db::postgresql examples' do
|
|
context 'with only required parameters' do
|
|
let :params do
|
|
required_params
|
|
end
|
|
|
|
it { should contain_postgresql__server__db(title).with(
|
|
:user => title,
|
|
:password => 'md557ae0608fad632bf0155cb9502a6b454'
|
|
)}
|
|
end
|
|
|
|
context 'when overriding encoding' do
|
|
let :params do
|
|
required_params.merge!( :encoding => 'latin1' )
|
|
end
|
|
|
|
it { should contain_postgresql__server__db(title).with_encoding(params[:encoding]) }
|
|
end
|
|
|
|
context 'when omitting the required parameter password_hash' do
|
|
let :params do
|
|
{}
|
|
end
|
|
|
|
it { should raise_error(Puppet::Error) }
|
|
end
|
|
|
|
context 'when notifying other resources' do
|
|
let :pre_condition do
|
|
"include postgresql::server
|
|
exec { 'nova-db-sync': }"
|
|
end
|
|
|
|
let :params do
|
|
required_params.merge!( :notify => 'Exec[nova-db-sync]' )
|
|
end
|
|
|
|
it { should contain_exec('nova-db-sync').that_subscribes_to("Openstacklib::Db::Postgresql[#{title}]") }
|
|
end
|
|
|
|
context 'when required for other openstack services' do
|
|
let :pre_condition do
|
|
"include postgresql::server
|
|
service {'keystone':}"
|
|
end
|
|
|
|
let :title do
|
|
'keystone'
|
|
end
|
|
|
|
let :params do
|
|
required_params.merge!( :before => 'Service[keystone]' )
|
|
end
|
|
|
|
it { should contain_service('keystone').that_requires("Openstacklib::Db::Postgresql[keystone]") }
|
|
end
|
|
|
|
context 'when deprecated password_hash is used' do
|
|
let :params do
|
|
{ :password_hash => 'md557ae0608fad632bf0155cb9502a6b454' }
|
|
end
|
|
|
|
it { should contain_postgresql__server__db(title).with(
|
|
:user => title,
|
|
:password => 'md557ae0608fad632bf0155cb9502a6b454'
|
|
)}
|
|
end
|
|
end
|
|
|
|
on_supported_os({
|
|
:supported_os => OSDefaults.get_supported_os
|
|
}).each do |os,facts|
|
|
context "on #{os}" do
|
|
let (:facts) do
|
|
facts.merge!(OSDefaults.get_facts())
|
|
end
|
|
|
|
it_behaves_like 'openstacklib::db::postgresql examples'
|
|
end
|
|
end
|
|
end
|