openstack
/
puppet-oslo
Code Issues Proposed changes

Fix the wrong default value of idle_timeout 

Currently we always get the following warnings because of the wrong
default value of idle_timeout.

The idle_timeout parameter is deprecated.
Please use connection_recycle_time instead.

This change fixes the default and ensures that the warning message
is shown only when the deprecated parameter is set.

Change-Id: Iba93ffdacf45096a6db65f3f0dfcfaf7d87574f2
(cherry picked from commit 12e2f4a886)
(cherry picked from commit 69263d76c1)
This commit is contained in:
Takashi Kajinami 2021-02-15 09:44:09 +09:00
parent a5869c721e
commit 06766e8789
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/db.pp
View File

@ -136,7 +136,7 @@ define oslo::db(
$db_max_retries = $::os_service_default,
$use_tpool = $::os_service_default,
# DEPRCATED PARAMETERS
$idle_timeout = $::os_service_default,
$idle_timeout = undef,
$min_pool_size = undef,
) {
@ -183,7 +183,7 @@ define oslo::db(
}
}
if $idle_timeout {
if $idle_timeout != undef {
warning('The idle_timeout parameter is deprecated. Please use connection_recycle_time instead.')
}