openstack
/
puppet-panko
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I068b0a1704cc26afa332db79409cba55b56ed115
This commit is contained in:
Takashi Kajinami 2020-08-31 17:54:21 +09:00
parent a39b2938ab
commit 685a251d87
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -69,9 +69,6 @@ class panko::db (
warning('The database_min_pool_size parameter is deprecated, and will be removed in a future release.')
}
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection,
['^(sqlite|mysql(\+pymysql)?|postgresql(\+psycopg2)?):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'panko_config':
connection => $database_connection,
connection_recycle_time => $database_connection_recycle_time,